feat: Chat API and design refinements by devongovett · Pull Request #10577 · adobe/react-spectrum

devongovett · 2026-09-04T23:24:08Z

Adjusts spacing to match design specs
Adds scroll fade on the thread
Moves some styles from the stories into the Chat/Thread components and generally simplifies the API
update docs

TODO:

look at inline TODO comments in code, mostly API questions
- Should the scroll button be optional? ans: no (for now at least)
- Auto-wrap ThreadItem? ans: yes but if we auto-wrap it inside a ThreadItem but that means ThreadItem's own props like isStreaming, textValue, and id are no longer reachable unless we bring those props up to the UserMessage (and others) level. Might be weird to have ThreadItem specific props if the component is used standalone. So deferring for now until the ai components are more stable and we know which are going to be used standalone and which will be used inside Thread only. Allowing users to wrap them individually gives more flexibility for now
- Allow users to configure the GridList styles in Thread? ans: Enforce it for now, add it to coworkers first and then maybe can determine what things might need to be configurable
decide if we want to have a "style-less" version as well
- yes, will want a style-less version, team seems okay to defer this for now
Export scrollFade (Daniel P to do)

rspbot · 2026-09-04T23:27:38Z

Build successful! 🎉

rspbot · 2026-09-09T00:17:23Z

Build successful! 🎉

rspbot · 2026-09-09T23:17:23Z

Build successful! 🎉

This reverts commit 6c1cccc.

rspbot · 2026-09-10T22:26:48Z

Build successful! 🎉

rspbot · 2026-09-22T20:28:25Z

Build successful! 🎉

rspbot · 2026-09-24T22:12:05Z

Build successful! 🎉

LFDanLu

looks good for the most part, just some small things I noticed

LFDanLu · 2026-09-25T20:22:17Z

 import {DOMRef, forwardRefType, Node} from '@react-types/shared';
 import {filterDOMProps} from 'react-aria/filterDOMProps';
 import {focusRing, style, StyleString} from '@react-spectrum/s2/style' with {type: 'macro'};
+// @ts-ignore


mega nit, this is misplaced now, but tbh the intl file imports not having these don't even fail lint

LFDanLu · 2026-09-25T20:31:36Z

+            zIndex: 1
+          })}>
+          <ThreadScrollButton>
+            <ActionButton slot="scroll" aria-label="Scroll to bottom">


needs localization

LFDanLu · 2026-09-25T20:33:05Z

-        // TODO: for now we enforce this, but to be configurable?
-        style={
-          {
+    <div


this outer div has the same styles as the div under it plus both add the user provided styles, is that intentional?

hmmm i don't think that was intentional

LFDanLu · 2026-09-25T20:36:19Z

+          <ThreadScrollButton>
+            <ActionButton slot="scroll" aria-label="Scroll to bottom">
+              <ChevronDown />
+            </ActionButton>
+          </ThreadScrollButton>
+        </div>


now that we provide this for the user, do we need to export/document the scroll button anymore?

good point, probably not

rspbot · 2026-09-25T22:02:57Z

Build successful! 🎉

LFDanLu

pushed some small changes to remove extra instances of the scroll button, otherwise LGTM

rspbot · 2026-09-25T23:09:46Z

Build successful! 🎉

rspbot · 2026-09-25T23:09:46Z

## API Changes

@react-spectrum/ai

/@react-spectrum/ai:AttachmentGrid

-AttachmentGrid <T> {
-  align?: 'start' | 'center' | 'end' = 'start'
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  children?: ReactNode | (T) => ReactNode
-  dependencies?: ReadonlyArray<any>
-  id?: string
-  items?: Iterable<T>
-  styles?: StyleString
-}

/@react-spectrum/ai:AttachmentGridItem

-AttachmentGridItem {
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  children: ReactNode
-  id?: Key
-  isInvalid?: boolean
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL'
-  styles?: StyleString
-  textValue?: string
-  uploadProgress?: number
-}

/@react-spectrum/ai:ThreadScrollButton

-ThreadScrollButton {
-  children?: ReactNode
-}

/@react-spectrum/ai:AttachmentGridProps

-AttachmentGridProps <T> {
-  align?: 'start' | 'center' | 'end' = 'start'
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  children?: ReactNode | (T) => ReactNode
-  dependencies?: ReadonlyArray<any>
-  id?: string
-  items?: Iterable<T>
-  styles?: StyleString
-}

/@react-spectrum/ai:AttachmentGridItemProps

-AttachmentGridItemProps {
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  children: ReactNode
-  id?: Key
-  isInvalid?: boolean
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL'
-  styles?: StyleString
-  textValue?: string
-  uploadProgress?: number
-}

/@react-spectrum/ai:ThreadScrollButtonProps

-ThreadScrollButtonProps {
-  children?: ReactNode
-}

rspbot · 2026-09-25T23:09:48Z

Agent Skills Changes

Modified (9)

react-aria/agent-skills/index.json $\color{green}{+1}$ $\color{red}{-1}$
react-aria/agent-skills/react-aria.tar.gz
react-aria/agent-skills/react-aria/references/components/Separator/useSeparator.md $\color{green}{+1}$ $\color{red}{-1}$
s2/agent-skills/index.json $\color{green}{+3}$ $\color{red}{-3}$
s2/agent-skills/migrate-react-spectrum-v3-to-s2.tar.gz
s2/agent-skills/react-spectrum-s2.tar.gz
s2/agent-skills/react-spectrum-s2/references/guides/ai-components.md $\color{green}{+56}$ $\color{red}{-128}$
s2/agent-skills/react-spectrum-s2/references/react-aria/components/Separator/useSeparator.md $\color{green}{+1}$ $\color{red}{-1}$
s2/agent-skills/spectrum-audit.tar.gz

Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/5ebd1884871d7c3dcb43f65e5af92de4d8c72692/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/5ebd1884871d7c3dcb43f65e5af92de4d8c72692/

feat: Chat API and design refinements

ac3c856

github-actions Bot added Chat AI labels Sep 4, 2026

yihuiliao added 4 commits September 8, 2026 15:40

fix padding when promptfield is size small

a5043e7

update docs

83d2c20

fix lint

23a054d

wrap user message in thread item if in thread

6c1cccc

github-actions Bot added S2 PromptField UserMessage labels Sep 8, 2026

yihuiliao added 2 commits September 8, 2026 17:06

fix lint

006b397

alphabet is hard

3ffdb8d

yihuiliao added 2 commits September 9, 2026 15:35

chat style consolidation

b1f6be0

fix lint

8c5e1d9

yihuiliao added 2 commits September 10, 2026 14:37

Revert "wrap user message in thread item if in thread"

ee45115

This reverts commit 6c1cccc.

cleanup

5c483be

github-actions Bot removed the UserMessage label Sep 10, 2026

Merge branch 'main' into chat-refinement

5632788

yihuiliao added this to RSP Component Milestones Sep 22, 2026

github-project-automation Bot moved this to 🩺 To Triage in RSP Component Milestones Sep 22, 2026

yihuiliao moved this from 🩺 To Triage to 🏗 In Progress in RSP Component Milestones Sep 22, 2026

yihuiliao self-assigned this Sep 22, 2026

yihuiliao marked this pull request as ready for review September 24, 2026 22:04

Merge branch 'main' into chat-refinement

2c5301c

yihuiliao added the release label Sep 24, 2026

LFDanLu reviewed Sep 25, 2026

View reviewed changes

LFDanLu added the ready for review label Sep 25, 2026

address review

a3be653

remove unneeded ThreadScrollButton export and usage

5ebd188

LFDanLu approved these changes Sep 25, 2026

View reviewed changes

Conversation

devongovett commented Sep 4, 2026 • edited by yihuiliao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rspbot commented Sep 4, 2026

Uh oh!

rspbot commented Sep 9, 2026

Uh oh!

rspbot commented Sep 9, 2026

Uh oh!

rspbot commented Sep 10, 2026

Uh oh!

rspbot commented Sep 22, 2026

Uh oh!

rspbot commented Sep 24, 2026

Uh oh!

LFDanLu left a comment

Choose a reason for hiding this comment

Uh oh!

LFDanLu Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

LFDanLu Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

LFDanLu Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

yihuiliao Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

LFDanLu Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

yihuiliao Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

rspbot commented Sep 25, 2026

Uh oh!

LFDanLu left a comment

Choose a reason for hiding this comment

Uh oh!

rspbot commented Sep 25, 2026

Uh oh!

rspbot commented Sep 25, 2026

@react-spectrum/ai

/@react-spectrum/ai:AttachmentGrid

/@react-spectrum/ai:AttachmentGridItem

/@react-spectrum/ai:ThreadScrollButton

/@react-spectrum/ai:AttachmentGridProps

/@react-spectrum/ai:AttachmentGridItemProps

/@react-spectrum/ai:ThreadScrollButtonProps

Uh oh!

rspbot commented Sep 25, 2026

Agent Skills Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

devongovett commented Sep 4, 2026 •

edited by yihuiliao

Loading