Repository navigation
[C++] Escape quote and backslash when writing a single char field as JSON - #1142
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
operator<<writes a singlecharfield between quotes without escaping it, so a field holding"or\prints"code": """or"code": "\", which is not valid JSON. Both are now escaped, asget*AsJsonEscapedString()already does for char arrays. Thestd::isprintargument is also cast tounsigned char, since passing a negativecharis undefined behaviour.Verified: the new
JsonCharTestfails on master for"and\, and passes with this change (GCC 12 on arm64 Linux with ASan/UBSan, and AppleClang through CMake).