Repository navigation
Conversation
The image cache GC logged each pass but emitted no metric, so nobody could see whether it ran or why it fell short. Add ate.imagecache.gc.passes, labeled complete, shortfall, skipped or quiet. Quiet passes and the early skips count too, so a count that stops rising means the GC stopped. Signed-off-by: Ivy <igooch@google.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3782.
The image cache GC logs each pass but emits no metric. This adds
ate.imagecache.gc.passes, a counter byate.imagecache.gc.outcome:complete,shortfall,skippedorquiet. Unlikeate.filecache.gc.passes, quiet passes count too, and so do the early exits when atelet can't measure the volume or the cache, so a count that stops rising means the collector stopped.The registry, the observability guide and the image cache blind spot in
docs/metrics/substrate.yamlare updated. The pool size, the next item in #3782, comes in a separate PR.AI use: AI-assisted. Claude Code wrote the change and ran it on a GKE cluster. I reviewed it.