Repository navigation
objectstore: singleflight STS mints and retry - #3838
Draft
Diamond (diamondburned) wants to merge 1 commit into
Draft
Diamond (diamondburned) wants to merge 1 commit into
Diamond (diamondburned) wants to merge 1 commit into
Conversation
Concurrent snapshot transfers for the same actor triggered duplicate STS token exchanges in gcsissuer.Issuer without retry on HTTP 429 or 5xx responses, while exchangeclient pinned each node's gRPC channel to a single ate-api-server pod via default pick_first balancing. Coalesce concurrent unforced Issuer.Issue calls per actor UID when an in-flight mint covers the requested grants, atomically evicting zero-waiter cancelled flights under Issuer.mu and preserving wider longer-lived cached entries across concurrent mints. Retry transient STS and IAM Credentials 429, 5xx, transport, and truncated-body errors with bounded jittered backoff, and configure round_robin load balancing on exchangeclient.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent snapshot transfers for the same actor triggered duplicate STS token exchanges in
gcsissuer.Issuerwithout retry on HTTP 429 or 5xx responses, while exchangeclient pinned each node's gRPC channel to a single ate-api-server replica via defaultpick_firstload balancing.Issuer.Issuecalls per actor UID when an in-flight mint covers the requested grants, atomically evicting zero-waiter cancelled flights underIssuer.muand preserving wider longer-lived cached entries across concurrent mints.round_robingRPC load balancing on exchangeclient.Verification
go test -race -count=3 -shuffle=on ./internal/objectstoreplugin/... ./cmd/objectstore-plugin/..../hack/verify/boilerplate.sh && ./hack/verify/gofmt.sh && ./hack/verify/package-deps.sh🤖 PR was made with the use of generative AI.