Skip to content

feat(aidd-context): refresh cook recipes and validate practical guides - #521

Merged
alexsoyes merged 19 commits into
nextfrom
codex/recipes-clean
Oct 12, 2026
Merged

alexsoyes merged 19 commits into
nextfrom
codex/recipes-clean

Conversation

@alexsoyes

@alexsoyes alexsoyes commented Jul 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Restore the original English Markdown recipe scaffold, with optional Why, Verify, and difficulty sections.
  • Reduce the recipe contract to concise, non-duplicated principles and address the review comments on routing, references, and report assets.
  • Keep structural validation read-only and adaptable; fix file-read failures, symlinked entry points, and punctuation false positives.
  • Refresh the AIDDy, MCP, and token recipes; retire the two bundled project/feature flow guides. Correct the current RTK Codex hook guidance.

Validation

  • Independent review: cleanup and six-file Cook template follow-up approved, no remaining findings; all 19 supplied template criteria satisfied and 27 validator tests passed.
  • Global pre-commit: 576 script tests and 140 CLI architecture tests passed; manifests, typecheck, lint, paths, and Markdown links passed.
  • Pre-push: Knip passed; 6,795 CLI tests passed, one optional local Kilo-runtime test skipped.
  • JSON, YAML, TOML, and shell examples parsed successfully.
  • Fresh Codex flat and Claude marketplace distributions each returned the exact three-recipe validation PASS output.
  • Commit and push hooks ran without bypass. The latest commit is 476678cd.

The cleanup review and evidence are recorded in aidd_docs/tasks/2026_10/2026_10_01_cook-pr-cleanup/review.md. Remote CI, including Windows and CodeQL, passed on 476678cd; no open CodeQL alerts remain for this PR. Interactive client workflows were not executed.

Cook template conformance

The follow-up changes only the router and five actions, preserving their existing behavior. The recipe template, contract, recipes, references, and validator are unchanged by this follow-up. Paths below are relative to plugins/aidd-context/skills/12-cook/.

File Checked and corrected Remaining findings
SKILL.md Routing entries, handoffs, outcomes, repair loops, and the single shared index rule None
actions/01-list.md Ordered process, recipe listing guarantees, and observable Case / Pass tests None
actions/02-upsert.md Research evidence, new-only deduplication, bundled authorization, preservation, and repair reuse None
actions/03-research.md One-sentence process steps, source verification, complete outputs, and Case / Pass tests None
actions/04-apply.md Analysis before choice, per-file confirmation, human-only steps, and Case / Pass tests None
actions/05-validate.md Purpose sentence, section ownership, read-only checks, and optional parser disclosure None

A read-only independent checker reviewed all six complete files and their cited Cook contracts. Fresh Codex flat and Claude marketplace builds contain the six current files and return the exact three-recipe validator PASS output.

@alexsoyes
alexsoyes marked this pull request as ready for review August 7, 2026 06:41
@alexsoyes
alexsoyes requested a review from a team as a code owner August 7, 2026 06:41
@alexsoyes
alexsoyes enabled auto-merge (squash) August 7, 2026 07:03
@alexsoyes
alexsoyes requested a review from blafourcade August 16, 2026 01:56
Keep recipe steps actionable, enforce valid heading nesting, and preserve verified token and MCP guidance.
Separate durable agent instructions from scoped rules and keep each optimization technique directly actionable.
Keep bundled guidance concise, reproducible, and mechanically verifiable.
Keep lint settings compatible with the installed Biome schema.
@alexsoyes
alexsoyes force-pushed the codex/recipes-clean branch from 19c032e to 09f2d32 Compare August 24, 2026 06:30
@alexsoyes

Copy link
Copy Markdown
Contributor Author

@blafourcade t'es good dessus ?

Comment thread plugins/aidd-context/skills/12-cook/actions/02-upsert.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/references/research-playbook.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/references/recipe-contract.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/actions/05-validate.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/actions/05-validate.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/actions/05-validate.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/references/recipe-contract.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/SKILL.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/SKILL.md Outdated
Comment thread plugins/aidd-context/skills/12-cook/references/recipe-contract.md Outdated
@blafourcade blafourcade changed the title Refresh cook recipes and enforce heading hierarchy feat(aidd-context): refresh cook recipes and enforce heading hierarchy Aug 24, 2026
Keep the cook router, actions, and recipe contract consistent with the skill-generation rules and Baptiste's review feedback.
Comment thread plugins/aidd-context/skills/12-cook/scripts/validate-recipe.mjs Fixed
Comment thread plugins/aidd-context/skills/12-cook/scripts/validate-recipe.mjs Fixed
Comment thread scripts/__tests__/validate-recipe.test.js Fixed
Comment thread plugins/aidd-context/skills/12-cook/scripts/validate-recipe.mjs Fixed
Keep the original Markdown scaffold adaptable and let validation reject broken recipes without imposing editorial heuristics. Make file reads and symlinked entry points reliable.
@alexsoyes alexsoyes changed the title feat(aidd-context): refresh cook recipes and enforce heading hierarchy feat(aidd-context): refresh cook recipes and validate practical guides Oct 1, 2026
Comment thread plugins/aidd-context/skills/12-cook/scripts/validate-recipe.mjs Fixed
Accept native Windows line endings and derive heading anchors without regex-based tag stripping. Keep the symlink entry-point regression active across hosts.
Keep the removed shipping recipe deleted while retaining integration changes.
Expose one validator through the CLI so Cook, hooks and CI share the same checks without a bundled script.
Separate optional rollback from installation and clarify telemetry privacy and output-style activation.
@alexsoyes

Copy link
Copy Markdown
Contributor Author

C'est pas la panacée cette PR mais elle corrige déjà pas mal de choses par rapport à l'existant, j'aurais jamais du la créer c'est de l'over engineering le content devrait être sur Skool 😅

@alexsoyes alexsoyes removed their assignment Oct 9, 2026
Accept valid angle-wrapped Markdown destinations while preserving target and placeholder checks. Cover recipe and registration behavior missed by the mutation gate, and synchronize lock acquisition in its regression test.
Use single quotes in the recipe hook so it complies with the command quoting guard introduced on next.
The recipe hook builds the CLI, so Windows must install its dependencies before running commit hooks. Preserve build failures rather than attempting validation with an absent or stale binary.
@alexsoyes
alexsoyes merged commit d31fb5e into next Oct 12, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants