Skip to content

build: attempt to resolve test failure on CI #33925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crisbeto merged 1 commit into from
Oct 2, 2026
Merged

build: attempt to resolve test failure on CI #33925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 20 additions & 30 deletions src/material/tooltip/tooltip.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,10 +1243,6 @@ describe('MatTooltip', () => {
platform.ANDROID = true;
});

afterEach(() => {
jasmine.clock().uninstall();
});

it('should have a delay when showing on touchstart', async () => {
const fixture = TestBed.createComponent(BasicTooltipDemo);
fixture.detectChanges();
Expand Down Expand Up @@ -1288,58 +1284,52 @@ describe('MatTooltip', () => {
expect(event.defaultPrevented).toBe(false);
});

it('should close on touchend with a delay', () => {
jasmine.clock().install();
it('should close on touchend with a delay', async () => {
const fixture = TestBed.createComponent(BasicTooltipDemo);
fixture.detectChanges();
const button: HTMLButtonElement = fixture.nativeElement.querySelector('button');

dispatchFakeEvent(button, 'touchstart');
fixture.detectChanges();
jasmine.clock().tick(500); // Finish the open delay.
jasmine.clock().tick(0); // Finish the show delay.
await wait(500); // Finish the open delay.
await wait(0); // Finish the show delay.
fixture.detectChanges();
finishCurrentTooltipAnimation(overlayContainerElement, true); // Finish the animation.
assertTooltipInstance(fixture.componentInstance.tooltip, true);
const tooltip = fixture.componentInstance.tooltip;
assertTooltipInstance(tooltip, true);
const hideSpy = spyOn(tooltip._tooltipInstance!, 'hide').and.callThrough();

dispatchFakeEvent(button, 'touchend');
fixture.detectChanges();
jasmine.clock().tick(1000); // 2/3 through the delay
assertTooltipInstance(fixture.componentInstance.tooltip, true);

jasmine.clock().tick(500); // Finish the delay.
fixture.detectChanges();
finishCurrentTooltipAnimation(overlayContainerElement, false); // Finish the exit animation.

assertTooltipInstance(fixture.componentInstance.tooltip, false);
jasmine.clock().uninstall();
// The tooltip should start hiding using the `touchendHideDelay`, but remain visible for now.
expect(hideSpy).toHaveBeenCalledOnceWith(1500);
expect(tooltip._isTooltipVisible()).toBe(true);
assertTooltipInstance(tooltip, true);
});

it('should close on touchcancel with a delay', () => {
jasmine.clock().install();
it('should close on touchcancel with a delay', async () => {
const fixture = TestBed.createComponent(BasicTooltipDemo);
fixture.detectChanges();
const button: HTMLButtonElement = fixture.nativeElement.querySelector('button');

dispatchFakeEvent(button, 'touchstart');
fixture.detectChanges();
jasmine.clock().tick(500); // Finish the open delay.
jasmine.clock().tick(0); // Finish the show delay.
await wait(500); // Finish the open delay.
await wait(0); // Finish the show delay.
fixture.detectChanges();
finishCurrentTooltipAnimation(overlayContainerElement, true); // Finish the animation.
assertTooltipInstance(fixture.componentInstance.tooltip, true);
const tooltip = fixture.componentInstance.tooltip;
assertTooltipInstance(tooltip, true);
const hideSpy = spyOn(tooltip._tooltipInstance!, 'hide').and.callThrough();

dispatchFakeEvent(button, 'touchcancel');
fixture.detectChanges();
jasmine.clock().tick(1000); // 2/3 through the delay
assertTooltipInstance(fixture.componentInstance.tooltip, true);

jasmine.clock().tick(500); // Finish the delay.
fixture.detectChanges();
finishCurrentTooltipAnimation(overlayContainerElement, false); // Finish the exit animation.

assertTooltipInstance(fixture.componentInstance.tooltip, false);
jasmine.clock().uninstall();
// The tooltip should start hiding using the `touchendHideDelay`, but remain visible for now.
expect(hideSpy).toHaveBeenCalledOnceWith(1500);
expect(tooltip._isTooltipVisible()).toBe(true);
assertTooltipInstance(tooltip, true);
});

it('should disable native touch interactions', () => {
Expand Down
Loading