Repository navigation
Clear the attribute cursor when moving to the root - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the attribute cursor in
NodeNavigator.MoveToRoot. Navigating from an attribute back to the root currently retains its attribute index, soMoveToChildincorrectly returns false and other attribute-dependent operations can access the wrong node.The regression fails before the fix. Full tests and changed-file gofmt pass. Vet reports the existing
testing.T.Fatalfcall from a non-test goroutine atquery_test.go:210; that file is unchanged.