Repository navigation
GH-55440: [C++] Move bundled google-cloud-cpp libraries - #55319
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
|
As found in #55317 (comment), the following PR caused And also |
|
@github-actions crossbow submit test-debian-13-cpp-amd64 |
|
Revision: 2476a34 Submitted crossbow builds: ursacomputing/crossbow @ actions-1fd9f52c9c
|
|
|
|
@tadeja, I remembered about this issue now and was trying to find whether it was already fixed or not. Can I help with anything? |
2476a34 to
d152824
Compare
|
@github-actions crossbow submit test-debian-13-cpp-amd64 |
|
Revision: d152824 Submitted crossbow builds: ursacomputing/crossbow @ actions-b7baa33877
|
|
@github-actions crossbow submit r-binary-packages test-r-offline-maximal test-debian-13-cpp-amd64 |
|
Revision: 2e189b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-4af363edcb
|
|
@github-actions crossbow submit r-binary-packages test-r-offline-maximal test-debian-13-cpp-amd64 |
|
Revision: 04198cf Submitted crossbow builds: ursacomputing/crossbow @ actions-788d5c7556
|
|
@github-actions crossbow submit test-r-offline-maximal |
|
Revision: 04198cf Submitted crossbow builds: ursacomputing/crossbow @ actions-f295c03c10
|
|
@github-actions crossbow submit test-debian-13-cpp-amd64 |
|
Revision: 57f6da7 Submitted crossbow builds: ursacomputing/crossbow @ actions-8209b2703a
|
|
@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled test-ubuntu-24.04-cpp-gcc-13-bundled |
|
Revision: 57f6da7 Submitted crossbow builds: ursacomputing/crossbow @ actions-2f1460b1ff
|
| set(ARROW_GCS_BUNDLED_STATIC_LIBS | ||
| google-cloud-cpp::storage google-cloud-cpp::rest_internal google-cloud-cpp::common |
There was a problem hiding this comment.
I am still trying to get my head around why this is an issue but
list(PREPEND ARROW_BUNDLED_STATIC_LIBS ${AWSSDK_LINK_LIBRARIES})
isn't and we don't seem to require an ARROW_S3_BUNDLED_STATIC_LIBS
There was a problem hiding this comment.
ok, as this is green and fixes a real issue I think we should merge. We should probably create ARROW_S3_BUNDLED_STATIC_LIBS as this might be just coincidence that is not currently failing but we can do that afterwards.
There was a problem hiding this comment.
Tentatively created this one
|
@github-actions crossbow submit test-debian-13-cpp-amd64 test-ubuntu-22.04-cpp-bundled test-ubuntu-24.04-cpp-gcc-13-bundled |
|
Revision: 3b04d01 Submitted crossbow builds: ursacomputing/crossbow @ actions-b0e1ebe2bb
|
Rationale for this change
Fix #55440. This is a follow-up to #54905. Bundled
google-cloud-cppremained inlibarrow_bundled_dependencies.a, which broke static linking of non-GCS consumers such asarrow-example-s3-static.What changes are included in this PR?
google-cloud-cppinto a newlibarrow_gcs_bundled_dependencieslibrary, linked viaArrowGcs::arrow_gcs_staticandarrow-gcs.pc.cpp/examples/minimal_build.arrow_gcs_bundled_dependenciesinbuilding.rstAre these changes tested?
Yes. The new minimal_build static-link checks in CI C++ (
ARM64 macOS 26 C++or 15-intel C++ ...) and C++ Extra (AMD64 Debian SIMD Level NONEorAMD64 Alpine Linux...) and crossbowtest-debian-13-cpp-amd64Are there any user-facing changes?
Yes. Static builds with bundled
google-cloud-cppinstall a newlibarrow_gcs_bundled_dependencieslibrary.CMake and pkg-config users get it automatically, others must link it after
arrow_gcs.Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: