Repository navigation
fix(core): process and validate inputs before pre_run_step in astep (#979) - #995
Open
legend91019 wants to merge 1 commit into
Open
legend91019 wants to merge 1 commit into
legend91019 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #979.
Application.step()processes inputs before callingpre_run_step, butApplication.astep()previously passed the raw input dictionary to the hook before processing and validation. As a result, the hook could receive undeclared inputs or run before a missing required input was rejected.This change processes inputs before the async pre-step hook and passes the resulting
action_inputsto it, for both synchronous and asynchronous actions executed throughastep().Changes
burr/core/application.py: call_process_inputs(inputs, next_action)beforepre_run_stepin_astep()and reuse the processed inputs for async execution.tests/core/test_application.py: cover filtering undeclared inputs and rejecting missing required inputs before the hook runs, for sync and async actions.Verification
Implementation verification previously recorded for this branch:
tests/core/test_application.py: 144 tests passed.tests/core: 432 tests passed.This description-only update repairs Markdown escaping and corrupted identifiers. It does not change the branch or claim a new test run.