Skip to content

fix(grid): account for inverse axes when laying out the grid by outer bounds. close #21839 #21842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xh123637 wants to merge 1 commit into
base: master
Choose a base branch
from
+71 −0
Open

fix(grid): account for inverse axes when laying out the grid by outer bounds. close #21839 #21842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/coord/cartesian/Grid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,14 @@ function layOutGridByOuterBounds(
let proportion = axis.scale.normalize(
getTickValueOutermost(axis.scale, getLabelInner(labelInfo.label).labelInfo.tick)
);
// `normalize` is in data space and does not account for
// `inverse`, while the proportion below is measured in
// pixel space from the min edge of the grid. Flip it for
// inverse axes, otherwise a tick near one edge is treated
// as near the other edge and the grid collapses.
if (axis.inverse) {
proportion = 1 - proportion;
}
proportion = xyIdx === 1 ? 1 - proportion : proportion;
// xAxis use proportion on x, yAxis use proprotion on y, otherwise not.
fillMarginOnOneDimension(labelInfo.rect, xyIdx, proportion);
Expand Down
63 changes: 63 additions & 0 deletions test/ut/spec/component/grid.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.