Repository navigation
[FLINK-40695] Add a retry state for failed ExecutionGraph creation - #29290
Open
vahmed-hamdy wants to merge 7 commits into
Open
vahmed-hamdy wants to merge 7 commits into
vahmed-hamdy wants to merge 7 commits into
Conversation
Collaborator
vahmed-hamdy
commented
Sep 25, 2026
vahmed-hamdy
commented
Sep 25, 2026
vahmed-hamdy
commented
Sep 25, 2026
vahmed-hamdy
commented
Sep 25, 2026
…rengthen tests The retry strategy loader copied the prefixed configuration via Configuration#addAll(new DelegatingConfiguration(...)). Configuration#addAll reads the other config's inherited confData directly, but a DelegatingConfiguration keeps its data in the backing configuration and leaves confData empty, so the copy came out empty and every prefixed key was silently dropped. As a result the feature could never be enabled through configuration (the loader always fell back to no-restart). Read the prefixed configuration directly through the DelegatingConfiguration instead. Add ExecutionGraphCreationRetryStrategyFactoryLoaderTest covering per-type parsing, job-over-cluster precedence, prefixed per-type parameters, default no-restart, independence from the job's own restart-strategy, and unknown strategy handling (this pins the bug above). Move the AdaptiveScheduler EG-creation retry integration tests into a dedicated AdaptiveSchedulerExecutionGraphCreationRetryTest, which keeps AdaptiveSchedulerTest under the checkstyle file-length limit, and assert the numExecutionGraphCreationRetries metric on a successful retry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
community-reviewed
…tions The new jobmanager.adaptive-scheduler.retry-execution-graph-creation.restart-strategy.type option in JobManagerOptions references RestartStrategyOptions, so loading JobManagerOptions now transitively runs RestartStrategyType.<clinit>. That initializer built its alias sets with org.apache.commons.compress.utils.Sets, which is absent from slim classpaths such as the flink-table-jdbc driver bundle, producing a NoClassDefFoundError (org/apache/commons/compress/utils/Sets) when the JDBC driver initializes RestOptions -> JobManagerOptions. Replace the commons-compress Sets usage with plain JDK collections. Behavior is unchanged (allAvailableValues is still the main value plus its aliases), and the enum no longer pulls commons-compress onto the runtime classpath. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief change log
(for example:)
RetryExecutionGraphCreationAdaptiveScheduler stateRetryBackOffStrategyfor the new stateVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8