Repository navigation
IGNITE-29107 Add ClientConnector metric for current peak of running compute tasks - #13661
Merged
Merged
Conversation
shishkovilja
force-pushed
the
ignite-29107
branch
2 times, most recently
from
October 14, 2026 12:10
f3de6ff to
565cbba
Compare
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (3)
|
shishkovilja
force-pushed
the
ignite-29107
branch
2 times, most recently
from
October 19, 2026 10:26
0f3f676 to
164399c
Compare
shishkovilja
changed the title
shishkovilja
changed the title
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (5)
|
| long peak = super.value(); | ||
|
|
||
| // The current value can not exceed the limit, so there is no need to calculate it. | ||
| return peak >= limit ? peak : Math.max(peak, cur.getAsLong()); |
Contributor
There was a problem hiding this comment.
cur can be more than max only when metric is not updated more than time interval, in this case value is 0 and only in this case we need to calculate cur. limit filed is not required
Contributor
Author
There was a problem hiding this comment.
Limit
Limit is required currently because we should not re-calculate metric from sessions values:
- Limit <=0 - in this case compute taks are disabled for thin client. In fact,
0is the current value. - Value >= limit - in this case no new tasks will be executed. In fact,
value==limit.
Current and zero
cur can be more than max only when metric is not updated more than time interval
No, it can be such situation:
- Session 1 starts
Task1,Task2 - Interval was exceeded
Task1,Task2are still running, but metric is zero.- Session 2 starts
Task3 - Metric value will be updated to
1, not0, sovalue()will not be re-calculated and we get incorrect value -1insead of3.
However, I'll try to reduce re-calculations.
…he busiest connection
…ic to a MaxValueMetric
shishkovilja
force-pushed
the
ignite-29107
branch
from
October 23, 2026 12:08
164399c to
665a244
Compare
alex-plekhanov
approved these changes
Oct 26, 2026
alex-plekhanov
approved these changes
Oct 26, 2026
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (88)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.