Repository navigation
Conversation
Caideyipi
marked this pull request as draft
October 30, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Chinese builds still emit English diagnostics when inline format templates, helper arguments, and stored message variables bypass the compile-time message classes. Route 541 diagnostic sites through paired EN/ZH constants across Pipe API, subscription, CLI schema tools, node-commons, ConfigNode, and DataNode, adding 462 message keys.
The changes cover pipe validation and transfer errors, subscription polling and lifecycle errors, write/storage diagnostics, TsFile loading errors, and schema/metadata operations. Preserve the original English text, format arguments, status codes, and exception causes. Keep machine-facing identifiers and existing text-based classifiers unchanged, and use the Chinese missing-broker wording already recognized by subscription clients.
Validation
with-integration-tests.with-zh-locale,skipTests).The unit-test selection includes subscription status/lifecycle/connection handling,
SubscriptionInfoTest,TabletStatementConverterTest,LoadTsFileConsensusNodeTest,SettleRequestHandlerTest, and the three modules'TypeServicesTestclasses. No tests were added or modified.