Skip to content

Localize pipe, subscription, write, load, and metadata diagnostics - #19066

Draft
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:codex/localize-core-diagnostics
Draft

Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:codex/localize-core-diagnostics

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Chinese builds still emit English diagnostics when inline format templates, helper arguments, and stored message variables bypass the compile-time message classes. Route 541 diagnostic sites through paired EN/ZH constants across Pipe API, subscription, CLI schema tools, node-commons, ConfigNode, and DataNode, adding 462 message keys.

The changes cover pipe validation and transfer errors, subscription polling and lifecycle errors, write/storage diagnostics, TsFile loading errors, and schema/metadata operations. Preserve the original English text, format arguments, status codes, and exception causes. Keep machine-facing identifiers and existing text-based classifiers unchanged, and use the Chinese missing-broker wording already recognized by subscription clients.

Validation

  • Spotless applied to all six changed modules with with-integration-tests.
  • Static checks passed for EN/ZH key parity, format-specifier order, exact English text reuse, and message-only Java substitutions.
  • Remote JDK 17: clean full-reactor EN package and 75 existing unit tests across 10 test classes; zero failures or skipped tests.
  • Remote JDK 17: clean full-reactor ZH package with test compilation (with-zh-locale, skipTests).
  • Each locale used clean source and a separate fresh Maven repository, with matching TsFile dependencies rebuilt from source.

The unit-test selection includes subscription status/lifecycle/connection handling, SubscriptionInfoTest, TabletStatementConverterTest, LoadTsFileConsensusNodeTest, SettleRequestHandlerTest, and the three modules' TypeServicesTest classes. No tests were added or modified.

@Caideyipi
Caideyipi marked this pull request as draft October 30, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant