Repository navigation
HDDS-16883. Acceptance artifact not uploaded due to invalid stack dump filename for HAProxy container - #11474
Merged
Merged
Conversation
…p filename for HAProxy container create_stack_dumps lists Java processes with `bash -c "jps | grep -v Jps"`. The HAProxy s3g container (alpine) has no bash, and docker prints the "OCI runtime exec failed" error to stdout, which ends up in the stack dump filename. The quotes and colons in it make upload-artifact reject the whole acceptance artifact. HDDS-9027 fixed this with `sh -c`, which HDDS-11454 changed back to `bash -c`. Use `sh -c` again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
adoroszlai
approved these changes
Oct 11, 2026
adoroszlai
marked this pull request as ready for review
October 11, 2026 13:07
Contributor
|
Merged. Thanks @smengcl for working on this, @adoroszlai @Russole for the review. |
Contributor
Author
|
Thanks @adoroszlai @Russole @chungen0126 for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: Claude Code (Opus 5.5)
What changes were proposed in this pull request?
When a test fails in
ozone-ha/test-haproxy-s3g.sh, theacceptance-HA-unsecureartifact is not uploaded at all:create_stack_dumpslists Java processes withdocker exec "${c}" bash -c "jps | grep -v Jps". Thes3gservice in the HAProxy setup ishaproxy:lts-alpine, which has no bash. Docker prints theOCI runtime exec failederror to stdout, so it is read aspid procnameand becomes part of the stack dump filename.HDDS-9027 fixed this by using
sh -c, which HDDS-11454 changed back tobash -c. This patch usessh -cagain:jpsis not found in the HAProxy container, nothing reaches stdout, and no stack dump file is created for it.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16883
How was this patch tested?
haproxy:lts-alpinecontainer with stderr discarded:bash -c "jps | grep -v Jps"prints theOCI runtime exec failederror on stdout,sh -c "jps | grep -v Jps"prints nothing.hadoop-ozone/dev-support/checks/bats.shpasses.🤖 Generated with Claude Code