Repository navigation
HDDS-16884. Make backup compaction pruning test independent of automatic compaction - #11476
Merged
Merged
Conversation
rich7420
marked this pull request as ready for review
October 11, 2026 08:05
Contributor
|
@smengcl would you like to take a look? |
smengcl
approved these changes
Oct 13, 2026
Contributor
|
Thanks @rich7420 for the patch. Thanks @chungen0126 @adoroszlai for the reviews. |
Contributor
Author
|
@adoroszlai @smengcl @chungen0126 thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
testBackupCompactionFilesPruningBackgroundServicecan time out because snapshot creation does not guarantee a completed compaction with backup SST inputs to prune. Unrelated compactions can also affect the directory's total file count.Use the existing
CompactDBUtilto force a key-table compaction, capture its new backup SST inputs, and wait for those files to be pruned. Keep the leadership-transfer and snapshot-diff checks and the pruning timeout unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16884
How was this patch tested?
On
dcf49b11d8:TestSnapshotBackgroundServices#ALLpassed with JDK 25.