Skip to content

test: Replace HELPER_TOOLS with literal names in case files #1425

Description

@jirispilka

Problem

CONTRIBUTING.md (line 330) says integration tests must use hardcoded tool-name strings so a renamed tool fails the suite instead of silently following the constant. Every existing file in tests/test_kit/cases/ (storage.cases.ts, actors.cases.ts, tools.cases.ts, apps.cases.ts, tasks.cases.ts, payments.cases.ts, registration.cases.ts) uses HELPER_TOOLS.* instead.

Found as a pre-existing review finding on #1423, whose new schedules.cases.ts follows the rule. Too many files to fold into that PR.

Proposed fix

Replace HELPER_TOOLS.X with the literal tool name across tests/test_kit/cases/*.cases.ts, drop the now-unused import, and reconcile the wording in CLAUDE.md ("exception: integration tests") with CONTRIBUTING so both say the same thing. Or, if the maintainers prefer the constants, change CONTRIBUTING instead; either way the doc and the practice should match.

Context

Drafted by Claude Code during the #1394 shepherd run.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtCode quality improvement or decrease of technical debt.t-aiIssues owned by the AI team.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions