Repository navigation
test(Database): fix state leaks and random-order test determinism for MySQLi, PostgreSQL, and OCI8 - #10581
Open
gr8man wants to merge 7 commits into
Open
test(Database): fix state leaks and random-order test determinism for MySQLi, PostgreSQL, and OCI8#10581gr8man wants to merge 7 commits into
gr8man wants to merge 7 commits into
Conversation
carson-codeigniter4
Bot
added
github_actions
|
Hi there, @gr8man! 👋 It looks like this pull request does not follow our template:
Please update the description to follow the template. The |
gr8man
force-pushed
the
fix-postgres-tests
branch
from
September 23, 2026 20:11
7c62122 to
2bc665a
Compare
carson-codeigniter4
Bot
removed
the
needs template
gr8man
force-pushed
the
fix-postgres-tests
branch
2 times, most recently
from
September 25, 2026 23:30
7b7132e to
36e3579
Compare
gr8man
marked this pull request as draft
September 26, 2026 19:43
gr8man
marked this pull request as ready for review
September 26, 2026 21:03
Contributor
Author
|
Hey everyone! 👋 I've finished testing and cleaning up the branch. I stripped out all the unnecessary changes (especially the OCI8 experiments and non-essential tweaks in What remains now is (hopefully!) the bare minimum strictly required to make the database test suite deterministic and green under
All checks are green across the board now. The PR is ready for review! 🚀 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved cleanup, CI coverage, identifier quoting, assertion, and regression-test issues remain.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
This PR improves database test isolation and random-order determinism across supported drivers, while stabilizing PostgreSQL upsert constraint selection.
Changes:
- Adds per-component database and connection cleanup.
- Improves migration, table, and metadata state handling.
- Updates PostgreSQL upsert behavior and randomized-test CI configuration.
| File | Summary |
|---|---|
tests/system/Database/Migrations/MigrationRunnerTest.php |
Cleans migration locks; lock handling must prevent leaked migration state. |
tests/system/Database/Live/UpsertTest.php |
Updates database-aware expectations; add primary-versus-unique constraint regression coverage. |
tests/system/Database/Live/Postgre/ConnectTest.php |
Uses isolated PostgreSQL connections. |
tests/system/Database/Live/MySQLi/NumberNativeTest.php |
Isolates MySQLi connection settings. |
tests/system/Database/Live/MySQLi/FoundRowsTest.php |
Isolates MySQLi connection state. |
tests/system/Database/Live/MetadataTest.php |
Resets metadata state and restores prefixes. |
tests/system/Database/Live/GetVersionTest.php |
Adjusts version validation; malformed trailing values must remain rejected. |
tests/system/Database/Live/ForgeTest.php |
Adds cleanup; dependent tables must be dropped before parent tables. |
tests/system/Database/Live/ExecuteLogMessageFormatTest.php |
Handles varied backtrace formats. |
tests/system/Database/Live/ConnectTest.php |
Resets shared connection state. |
tests/_support/Database/Migrations/20160428212500_Create_test_tables.php |
Improves migration cleanup. |
tests/_support/Config/Registrar.php |
Creates isolated databases; MySQL identifiers need safe quoting. |
system/Database/Postgre/Builder.php |
Prefers primary constraints for upserts. |
.github/workflows/test-random-execution.yml |
Updates database CI setup; OCI8 coverage needs a verification path. |
.github/scripts/random-tests-config.txt |
Enables Database random testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| (int) $dbParams['port'], | ||
| ); | ||
| if (! $conn->connect_error) { | ||
| $conn->query('CREATE DATABASE IF NOT EXISTS ' . $conn->real_escape_string($dbParams['database'])); |
Comment on lines
+472
to
+475
| $uniqueIndexes = array_filter($tableIndexes, static function ($index) use ($fieldNames): bool { | ||
| $hasAllFields = count(array_intersect($index->fields, $fieldNames)) === count($index->fields); | ||
|
|
||
| return ($index->type === 'UNIQUE' || $index->type === 'PRIMARY') && $hasAllFields; | ||
| return $index->type === 'PRIMARY' && $hasAllFields; |
| $version = $this->db->getVersion(); | ||
|
|
||
| $this->assertMatchesRegularExpression('/\A\d+(\.\d+)*\z/', $version); | ||
| $this->assertMatchesRegularExpression('/\A\d+(\.\d+)*/', $version); |
gr8man
force-pushed
the
fix-postgres-tests
branch
from
September 27, 2026 16:41
61079dd to
804ce9d
Compare
… MySQLi, PostgreSQL, and OCI8 Fixes database tests to be deterministic under random execution order for MySQLi, PostgreSQL, and OCI8 drivers. Ref codeigniter4#9968. - Fix random-order test execution issues and state leakage under PostgreSQL, MySQL, and OCI8 - Isolate per-component database schemas for parallel random-test runs - Safely extract dbParams keys with null coalescing in Registrar - Drop team_members table in migration down method - Run Oracle components sequentially and exclude Oracle from the random test matrix (single shared schema via DSN causes ORA-00955 collisions) - Handle case-insensitive cached tableExists and catalog lookups in OCI8 - Fix OCI8 insertID() to preserve quoted table name case so Oracle USER_TAB_COLUMNS lookups match forge-created (lowercase) tables
…DELAYED_DURABILITY
gr8man
force-pushed
the
fix-postgres-tests
branch
from
October 10, 2026 13:00
4fc3f9b to
af7d2b3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes database tests to be deterministic under random execution order
for MySQLi, PostgreSQL, and OCI8 drivers. Ref: #9968
Ref: #9968
Checklist: