Skip to content

chore: fix release automation failures on the first run #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 1 commit into from
Oct 9, 2026
Merged

chore: fix release automation failures on the first run #10610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/verify-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
php-version: '8.2'
tools: composer
extensions: intl, gd
coverage: none
coverage: xdebug

- name: Wait for Packagist to serve the new framework version
run: |
Expand Down
14 changes: 12 additions & 2 deletions tests/system/AutoReview/UpdateUpgradeGuideTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function testErrorWhenUpgradeGuideIsMissing(): void

public function testDryRunPrintsSectionsWithoutWriting(): void
{
$this->assertFileExists($this->upgradePath);
$this->skipIfUpgradeGuideIsMissing();

exec(sprintf('php ./admin/update-upgrade-guide.php %s --dry-run 2>&1', $this->nextVersion), $output, $exitCode);
$outputString = implode("\n", $output);
Expand All @@ -88,7 +88,7 @@ public function testDryRunPrintsSectionsWithoutWriting(): void

public function testUpdatesUpgradeGuide(): void
{
$this->assertFileExists($this->upgradePath);
$this->skipIfUpgradeGuideIsMissing();

if (trim((string) exec("git status --porcelain -- {$this->upgradePath}")) !== '') {
$this->markTestSkipped('You have uncommitted changes to the upgrade guide that will be erased by this test.');
Expand All @@ -110,4 +110,14 @@ public function testUpdatesUpgradeGuide(): void
exec("git restore -- {$this->upgradePath}");
}
}

private function skipIfUpgradeGuideIsMissing(): void
{
if (! is_file($this->upgradePath)) {
$this->markTestSkipped(sprintf(
'%s does not exist yet. It is created by "php admin/create-new-changelog.php" after a release.',
$this->upgradePath,
));
}
}
}
Loading