Skip to content

fix: update Sparkle to 2.10.1 for its security fixes - #296

Merged
sreya merged 1 commit into
mainfrom
security-review-pshn
Nov 17, 2026
Merged

sreya merged 1 commit into
mainfrom
security-review-pshn

Conversation

@sreya

@sreya sreya commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Sparkle 2.7.0 is affected by CVE-2025-10015 and CVE-2025-10016, fixed in 2.7.2.

Sparkle 2.7.0 is affected by CVE-2025-10015 and CVE-2025-10016, fixed in
2.7.2. The second lets a local unprivileged process race to connect to
Autoupdate when it is started as root and have its own package installed,
which is how this app installs updates. Two further advisories,
CVE-2026-47121 and CVE-2026-47122, are fixed in 2.9.2.

- Pin Sparkle 2.10.1, the newest stable release.
- Download sign_update from the same release in release-sign.yml, with
  its checksum.
- Isolate UpdaterService to the main actor. Since Sparkle 2.8,
  SPUStandardUpdaterController, SPUUpdater and SPUUpdaterDelegate are
  marked NS_SWIFT_UI_ACTOR, which Swift 6 enforces. SUVersionDisplay and
  SPUStandardUserDriverDelegate are not, so the two methods implementing
  them are nonisolated.

Sparkle 2.10 requires macOS 12. The app requires macOS 14.
@sreya
sreya requested a review from a team November 17, 2026 21:02
@sreya
sreya requested a review from ethanndickson as a code owner November 17, 2026 21:02
@sreya
sreya merged commit e7ddddf into main Nov 17, 2026
6 checks passed
@sreya
sreya deleted the security-review-pshn branch November 17, 2026 21:08
@linear-code

linear-code Bot commented Nov 19, 2026

Copy link
Copy Markdown

SEC-1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants