Repository navigation
🤖 ci: sign macOS builds with coder/setup-apple-signing-action - #8189
Conversation
The action that built rcodesign left coder/coder-desktop-macos for its own repository. The pin here names a commit that no branch of that repository's main line holds any more. The new action builds the same revision with the same patch and reports the path and the sha256 of the binary.
…-signing-action The shared action installs the same libkmsp11 release by the same sha256, writes the certificate and the library configuration, and prints which certificate signs. The Sign step reads the three paths from its outputs.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🟢 e2e stories (Haiku): 14 passed21 agent steps · 6 replayed from cache · 15 model calls · 47.8k tokens (27% cached) All 14 tests in 9 files
e2e 0.20.0 · 1m 35s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 7.9k tokens (33% cached) All 3 tests in 3 files
e2e 0.20.0 · 27.9s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 8.0s · 2 targets (web, phone) · run artifacts |
Version bump for the v0.32.4 patch release, done with `node ./scripts/set-package-version.js 0.32.4` so the root `package.json` and the legacy `packages/mux-compat` package stay version-locked. It carries the 6 commits on main since v0.32.3: macOS nightlies and releases are now signed and notarised on Linux with a key in Cloud KMS (coder#8178, coder#8189, coder#8179, coder#8190), an experiment whose options live in another Settings section gets a button to them beside its switch (coder#8187), and two test fixes (coder#8184). This'll be the first stable release signed that way. Once this merges, we'll publish the GitHub Release `v0.32.4` on the squash commit, which starts the desktop, Docker (`latest`), VS Code and npm (`latest`) pipelines. --- _Generated with `xum` • Model: `anthropic:claude-fable-5-2` • Thinking: `xhigh`_ <!-- mux-attribution: model=anthropic:claude-fable-5-2 thinking=xhigh -->
Part of MUX-419. Follows #8178.
Summary
_sign-macos.ymlnow takesrcodesignand the Cloud KMS signing setup fromcoder/setup-apple-signing-action, the action that coder/coder, coder/coder-desktop-macos and coder/coder-desktop-windows use. The pin is the same commit as theirs.Background
#8178 built
rcodesignwithcoder/coder-desktop-macos/.github/actions/install-rcodesign. coder/coder-desktop-macos#303 removed that action when the shared repository replaced it, so the pin here names a commit that is not on that repository'smain. It still resolves, but nothing maintains it.Implementation
coder/setup-apple-signing-action/rcodesignbuilds the sameapple-platform-rsrevision with the same Rust toolchain and the same PKCS#11 patch as the old action. Itspathandsha256outputs replace the fixed path and the checksum step.coder/setup-apple-signing-actionreplaces the step that installedlibkmsp11and the half of the next step that wrote the certificate. It installs the samelibkmsp111.9 archive by the same sha256, checks the certificate and prints its subject and serial number, and writes the library configuration.Signreads the three paths from its outputs.These parts stay in this repository: the two jobs with the sha256 handover, the refusal of a commit that is not on
main, the notarization key check, the Google Cloud sign-in, the throwaway path, and the sign, notarize and staple steps.One behaviour changes: when the certificate or the key ring is missing or malformed, the error names the action input (
certificate-pem,key-ring), not the secret.Validation
rcodesignwith the new action and signs with it in the throwaway chain.mainafter the merge. coder/coder-desktop-macos runs the same commit of it with its release key.Risks
The same as #8178: a fault on the release-key path fails
main's macOS build, and nothing publishes from it. PR and merge-queue runs do not use that path.Generated with
xum• Model:anthropic:claude-fable-5-2• Thinking:xhigh