Skip to content

🤖 ci: sign macOS builds with coder/setup-apple-signing-action - #8189

Merged
ethanndickson merged 2 commits into
mainfrom
ethan/mux-419-signing-action
Nov 20, 2026
Merged

ethanndickson merged 2 commits into
mainfrom
ethan/mux-419-signing-action

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Part of MUX-419. Follows #8178.

Summary

_sign-macos.yml now takes rcodesign and the Cloud KMS signing setup from coder/setup-apple-signing-action, the action that coder/coder, coder/coder-desktop-macos and coder/coder-desktop-windows use. The pin is the same commit as theirs.

Background

#8178 built rcodesign with coder/coder-desktop-macos/.github/actions/install-rcodesign. coder/coder-desktop-macos#303 removed that action when the shared repository replaced it, so the pin here names a commit that is not on that repository's main. It still resolves, but nothing maintains it.

Implementation

  • Build job: coder/setup-apple-signing-action/rcodesign builds the same apple-platform-rs revision with the same Rust toolchain and the same PKCS#11 patch as the old action. Its path and sha256 outputs replace the fixed path and the checksum step.
  • Sign job: coder/setup-apple-signing-action replaces the step that installed libkmsp11 and the half of the next step that wrote the certificate. It installs the same libkmsp11 1.9 archive by the same sha256, checks the certificate and prints its subject and serial number, and writes the library configuration. Sign reads the three paths from its outputs.

These parts stay in this repository: the two jobs with the sha256 handover, the refusal of a commit that is not on main, the notarization key check, the Google Cloud sign-in, the throwaway path, and the sign, notarize and staple steps.

One behaviour changes: when the certificate or the key ring is missing or malformed, the error names the action input (certificate-pem, key-ring), not the secret.

Validation

  • This PR's CI builds rcodesign with the new action and signs with it in the throwaway chain.
  • The setup action runs only on the release-key path, so its first run here is the first push to main after the merge. coder/coder-desktop-macos runs the same commit of it with its release key.

Risks

The same as #8178: a fault on the release-key path fails main's macOS build, and nothing publishes from it. PR and merge-queue runs do not use that path.


Generated with xum • Model: anthropic:claude-fable-5-2 • Thinking: xhigh

The action that built rcodesign left coder/coder-desktop-macos for its own
repository. The pin here names a commit that no branch of that repository's
main line holds any more. The new action builds the same revision with the
same patch and reports the path and the sha256 of the binary.
…-signing-action

The shared action installs the same libkmsp11 release by the same sha256,
writes the certificate and the library configuration, and prints which
certificate signs. The Sign step reads the three paths from its outputs.
@linear-code

linear-code Bot commented Nov 20, 2026

Copy link
Copy Markdown

MUX-419

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T01:16:22.300242Z 1bc6d1d Manual request
🔒 Security Review ✅ Completed 2026-11-20T01:18:39.122320Z 1bc6d1d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 1bc6d1da67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 1bc6d1da67

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 e2e stories (Haiku): 14 passed

21 agent steps · 6 replayed from cache · 15 model calls · 47.8k tokens (27% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files
Test Agent Time
🟢 chatRestart.e2e.ts · 1 passed 1 step · 1 call 8.0s
🟢 a chat survives a restart of the server 1 step · 1 call 8.0s
🟢 compaction.e2e.ts · 1 passed 1 step · 1 call 8.5s
🟢 /compact replaces the old chat with a summary 1 step · 1 call 8.5s
🟢 pluginTrustRestart.e2e.ts · 1 passed 3 steps · 2 calls 10.0s
🟢 a trusted plugin hook stays trusted after the server restarts 3 steps · 2 calls 10.0s
🟢 settingsRoundTrip.e2e.ts · 1 passed 2 steps · 1 call 9.9s
🟢 a chat survives trips through Settings 2 steps · 1 call 9.9s
🟢 sidebarPerWorkspace.e2e.ts · 1 passed 4 steps · 1 call 5.5s
🟢 a new workspace starts with its right sidebar collapsed while another keeps it open 4 steps · 1 call 5.5s
🟢 smoke.e2e.ts · 1 passed 2 steps · 1 call 2.9s
🟢 the agent opens the playground workspace 2 steps · 1 call 2.9s
🟢 streamErrors.e2e.ts · 1 passed 1 step · 1 call 10.7s
🟢 stream errors show in the chat, and the chat recovers 1 step · 1 call 10.7s
🟢 todoNudge.e2e.ts · 1 passed 1 step · 1 call 6.7s
🟢 the agent finishes open TODO items after the turn-end nudge 1 step · 1 call 6.7s
🟢 touchAlignment.e2e.ts · 6 passed 6 steps · 6 calls 28.7s
🟢 the Settings close button is level with the title on a touch screen 390px wide 1 step · 1 call 5.0s
🟢 the Settings close button is level with the title on a touch screen 768px wide 1 step · 1 call 6.2s
🟢 Backup settings checkboxes are small and level with their labels on a touch phone 1 step · 1 call 5.0s
🟢 the heartbeat checkbox is small and level with its label on a touch phone 1 step · 1 call 3.9s
🟢 a reply's model and time stay on one line on a touch phone 1 step · 1 call 3.7s
🟢 the workspace actions menu stays on the title row on a touch phone 1 step · 1 call 4.9s

e2e 0.20.0 · 1m 35s · web · run artifacts

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 7.9k tokens (33% cached)
Spend: $0.01 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files
Test Agent Time
🟢 electron/deepLink.e2e.ts · 1 passed 1 step · 1 call 8.5s
🟢 a deep link of a second launch starts a chat in the running app 1 step · 1 call 8.5s
🟢 electron/menuBar.e2e.ts · 1 passed 1 step · 1 call 6.6s
🟢 the workspace menu bar is the desktop title bar 1 step · 1 call 6.6s
🟢 electron/smoke.e2e.ts · 1 passed 1 step · 1 call 9.8s
🟢 Xum Electron opens the playground workspace 1 step · 1 call 9.8s

e2e 0.20.0 · 27.9s · electron · run artifacts

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

e2e 0.20.0 · 8.0s · 2 targets (web, phone) · run artifacts

@ethanndickson
ethanndickson added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit a49adc9 Nov 20, 2026
45 checks passed
@ethanndickson
ethanndickson deleted the ethan/mux-419-signing-action branch November 20, 2026 01:55
yermakoffivan pushed a commit to yermakoffivan/mux that referenced this pull request Nov 20, 2026
Version bump for the v0.32.4 patch release, done with `node
./scripts/set-package-version.js 0.32.4` so the root `package.json` and
the legacy `packages/mux-compat` package stay version-locked.

It carries the 6 commits on main since v0.32.3: macOS nightlies and
releases are now signed and notarised on Linux with a key in Cloud KMS
(coder#8178, coder#8189, coder#8179, coder#8190), an experiment whose options live in
another Settings section gets a button to them beside its switch
(coder#8187), and two test fixes (coder#8184). This'll be the first stable release
signed that way.

Once this merges, we'll publish the GitHub Release `v0.32.4` on the
squash commit, which starts the desktop, Docker (`latest`), VS Code and
npm (`latest`) pipelines.

---

_Generated with `xum` • Model: `anthropic:claude-fable-5-2` • Thinking:
`xhigh`_

<!-- mux-attribution: model=anthropic:claude-fable-5-2 thinking=xhigh
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant