Conversation
The two test30-numa-disabled tests boot the node with a kernel which
has NUMA support compiled out, and boot it back at the end by calling
enable-numa as their last statement. A failure anywhere in between
never gets there: error exits the test, so the node keeps running the
kernel without NUMA. If we are running multiple tests, every test
after the failure sees a machine with a single node... and will fail.
Restore the kernel from an EXIT trap instead, the way the tests which
have state to put back already do it, and let enable-numa return
without doing anything if NUMA is enabled, so that calling it when
there is nothing to restore is free.
Looking into a failure of these tests is easier on a node which still
has NUMA disabled, so take keep_numa_disabled=1 to leave it that way:
keep_numa_disabled=1 ./run_tests.sh \
policies.test-suite/balloons/n4c16/test30-numa-disabled
Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/e2e/restore-numa-on-failure
branch
from
September 15, 2026 21:22
934b40a to
99221d0
Compare
Collaborator
Author
|
Closing in favor of a stacked set of PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two test30-numa-disabled tests boot the node with a kernel which has NUMA support compiled out, and boot it back at the end by calling enable-numa as their last statement. A failure anywhere in between never gets there: error exits the test, so the node keeps running the kernel without NUMA. If we are running multiple tests, every test after the failure sees a machine with a single node... and will fail.
Restore the kernel from an EXIT trap instead, the way the tests which have state to put back already do it, and let enable-numa return without doing anything if NUMA is enabled, so that calling it when there is nothing to restore is free.
Looking into a failure of these tests is easier on a node which still has NUMA disabled, so take keep_numa_disabled=1 to leave it that way: