Repository navigation
PCBC-1085: GetReplica API improvements - #264
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The refactor preserves the strategy export contract, updates affected tests, and has no identified blocking issues.
0 open findings
What changed in this PR
Refines the replica-read API with validated strategy factories and dedicated wrapping options.
Changes:
- Introduces a concrete index strategy and separate wrapping options.
- Validates replica indices and updates related tests.
- Adds or corrects API version annotations to 4.6.0.
| File | Description |
|---|---|
| tests/KeyValueGetReplicaTest.php | Updates wrapping usage and index-validation tests. |
| Couchbase/ReplicaIndex.php | Adds version documentation. |
| Couchbase/GetReplicaStrategyFromIndexOptions.php | Introduces wrapping options. |
| Couchbase/GetReplicaStrategy.php | Adds index validation and abstract strategy export. |
| Couchbase/GetReplicaOptions.php | Documents API availability. |
| Couchbase/FromIndexGetReplicaStrategy.php | Implements index-based strategy export. |
| Couchbase/Exception/ReplicaIndexOutOfBoundsException.php | Adds version documentation. |
| Couchbase/Exception/ReplicaIndexCurrentlyUnavailableException.php | Adds version documentation. |
| Couchbase/Exception/DocumentNotFoundOnReplicaException.php | Adds version documentation. |
| Couchbase/Collection.php | Corrects the replica-read version annotation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
avsej
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.