Repository navigation
Fix the RubyGems step of the release publishing script - #284
Merged
Merged
Conversation
Motivation ---------- plan_rubygems_push returns the gems already on rubygems.org as an Array of [gem, spec] pairs. push_to_rubygems iterates it with each_value, which Array does not define. The step therefore raises NoMethodError on every run, in dry-run and with --execute, before any gem is pushed. Modifications ------------- The skip list holds the gem specification alone, and push_to_rubygems iterates it with each. Results ------- A dry run of the RubyGems step lists the gems already live and the gems it would push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
bin/publish-release.rbfails at the RubyGems step on every run, dry-run included:plan_rubygems_pushreturns the already-published gems as an Array of[gem, spec]pairs, andpush_to_rubygemsiterates it witheach_value.Change. The skip list holds the gem specification alone, and is iterated with
each.