Repository navigation
Remove unused XPath functions min, max, ReplaceAll, FontSizeGuess - #906
Merged
Merged
Conversation
None of these were called from any rule file or from Rust code via XPath. They were registered under a "Not used: remove??" comment. - Delete Min, Max and ReplaceAll and their registrations - Drop the XPath registration for FontSizeGuess; its only remaining use was em_from_value() from canonicalize.rs, which is now a free pub(crate) function
Linux library size: 0.59 MiB (-0.14%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
# Conflicts: # src/xpath_functions.rs
Collaborator
Author
|
update: unblocked this from the changes by l |
moritz-gross
marked this pull request as draft
October 28, 2026 23:44
NSoiffer
marked this pull request as ready for review
November 1, 2026 19:06
Collaborator
|
I guess at this point if the functions aren't being used, they probably aren't going to be used. So I'll reluctantly approve this cleanup. |
Collaborator
Author
whatever you think makes most sense. we can also reluctantly mark this part with a comment and see what has changed in a few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these were called from any rule file or from Rust code via XPath. They were registered under a "Not used: remove??" comment.