Skip to content

docs: add logo to remaining guide pages - #932

Closed
jay23606 wants to merge 1 commit into
daisy:mainfrom
jay23606:fix/717-add-logo-to-guides
Closed

jay23606 wants to merge 1 commit into
daisy:mainfrom
jay23606:fix/717-add-logo-to-guides

Conversation

@jay23606

Copy link
Copy Markdown

Fixes #717

Add the existing MathCAT logo to the user, translator, and developer guides, matching the library-users page.

Validation

  • Before: the issue was confirmed in the source—the logo was absent from these three pages. The Rust and docs test commands were not run on the base branch.
  • After: the Jekyll site build passes and the generated pages include the logo; cargo test and cargo test --features no-unsafe pass; cargo clippy and cargo clippy --features no-unsafe pass with warnings denied; git diff --check passes.
  • Not verified: visual appearance in a browser.

🤖 Generated with Claude Code

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
@moritz-gross

Copy link
Copy Markdown
Collaborator

issue #717 says:

Note: this is not #406.: the logo exists but it is either not present or not really designed properly for these pages.

How is this handled?

@github-actions

Copy link
Copy Markdown
Linux library size: 0.59 MiB (0.00%)
Revision Release liblibmathcat.so
Base (915eb18) 0.59 MiB (618,272 bytes)
PR (fafef8f) 0.59 MiB (618,272 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@NSoiffer

NSoiffer commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks for trying, but that's not correct. The logo should flow as part of the text as it does in https://daisy.github.io/MathCAT/. I'm closing this. Please open another PR if you can get the alignment correct.

@NSoiffer NSoiffer closed this Nov 1, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Done in MathCAT Project Board Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Logo is missing from some pages

3 participants