Repository navigation
Preserve tokens and test W3C intent speech - #938
Kostenkov-2021 wants to merge 5 commits into
Conversation
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
There was a problem hiding this comment.
I don't understand why you added these to the IntentMappings. These are defined elsewhere. Many of these are listed and commented out. Probably they should have a comment above them that says "speech rules defined elsehwere" for the commented out ones. For the others, commented out versions with the 'defined-elsewhere' comment should be added.
72aec71 to
d19d0c0
Compare
There was a problem hiding this comment.
I don't like test_core_speech() because it is just ru and en. Once it is more than just en (which probably should only be used to make sure something that is language independent but currently is not that disiplined), this should be split so that it is in each language's directory.
For tests in the intent directory, the tests should not be testing the language speech, they should be testing what the mathml turned into in the intent tree. The speech for that should go into Languages/lang/intent.rs.
|
I appreciate your contribution and catching the typo in definitions.yaml along the missing rules. Please take a look at my comments and refactor the tests. |
d31e230 to
92d9986
Compare
Prevent wrapper cleanup from dropping split function names, correct the `re` definition, and add bilingual speech and navigation coverage for W3C calculus and general intents.
Map definite integrals, derivatives, blanks, and invisible operators to English speech, and support both W3C and inferred repeating-decimal intent forms.
Drop explicit mappings for blank, integral, derivative, and invisible MathML operators from the English definitions, along with obsolete commented calculus mappings.
Document which speech intents are handled by shared or style-specific rules, and clarify why their duplicate definitions remain commented out.
Move W3C intent speech coverage into English and Russian test suites, exercising both speech styles, all verbosity levels, and semantic navigation. Set a stable English language baseline in intent tests to avoid host-locale-dependent fixities.
92d9986 to
eb8b44b
Compare
Prevent wrapper cleanup from dropping split function names, correct the
redefinition, and add bilingual speech and navigation coverage for W3C calculus and general intents.Related PR and CI status
Related to #939. These PRs split the common/English changes and bilingual W3C intent tests (#938) from the Russian rules and regression coverage (#939).
The bilingual tests in this PR require the Russian rule changes from #939. When the PRs are tested separately, missing counterpart changes can therefore cause CI failures. Validate the combined changes and rerun CI after integration.
There is also a separate blocker in #939:
tests/Languages/ru/w3c_core_expected.tsvis referenced by a test but is missing from that PR. That fixture must be included before the combined test suite can pass.