Skip to content

Update mtable related rule and tests, based with commit 9175f812bff5d1f80894d7a32c3d824ff0336c08 - #944

Open
hammera wants to merge 2 commits into
daisy:mainfrom
hammera:main
Open

hammera wants to merge 2 commits into
daisy:mainfrom
hammera:main

Conversation

@hammera

@hammera hammera commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Hi Boys,

@NSoiffer, Based with @moritz-gross 9175f81 commit with english Rules/Languages/en/Sharedrules/default.yaml file, I updated affected mtable related rule the proper hungarian rule file, and added new tests in to the tests/Languages/hu/mtable.rs file.
I adapted following commit patch with hungarian affected rule and test file:

commit 9175f812bff5d1f80894d7a32c3d824ff0336c08
Author: Moritz Groß <hi@mgross.dev>
Date:   Sat Oct 31 03:31:49 2026 +0100

    Speak unfenced tables without "comma" between rows (#890) (#915)
    
    A table with no fences gets the `array` intent, but English had no speech
    rule for `array`, so it fell through to the catch-all function rule
    ("array of x comma y") and spoke "comma" between the rows.
    
    The English default table rule now handles `array` as well as `mtable`,
    as Portuguese already does. This also fixes `NumColumns=1` (missing `$`),
    which always gave "columns", e.g. "1 columns".
    
    Updates 4 expected strings in tests/Languages/en/mtable.rs and adds a
    test using the MathML from the issue.

All working fine with hungarian rules related with I doed, local way tested this.
Translator audit tool not producing condition differences with rules related, and add following general summary result:

│                 SUMMARY                                                      │
│   Files checked                     12                                       │
│   Files with issues                 3                                        │
│   Files OK                          9                                        │
│   Missing rules                     4                                        │
│   Untranslated text                 0                                        │
│   Rule differences                  0                                        │
│   Extra rules                       19                                       │
│   Missing definitions               0                                        │
│   Definition type mismatches        0                                        │
│   Extra definitions                 0                                        │

Please merge this change to the main branch, to upstream level landing this change if you have a little time.

Attila

…nge with commas related, basic with english change

Signed-off-by: Attila Hammer <hammera@pickup.hu>
… tests based with new english tests

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@hammera hammera changed the title Uopdate mtable related rule and tests, based with commit 9175f812bff5d1f80894d7a32c3d824ff0336c08 Update mtable related rule and tests, based with commit 9175f812bff5d1f80894d7a32c3d824ff0336c08 Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Linux library size: 0.59 MiB (0.00%)
Revision Release liblibmathcat.so
Base (c6bba2f) 0.59 MiB (618,920 bytes)
PR (78e1bc9) 0.59 MiB (618,920 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@hammera

hammera commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, all checks are passed right.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant