Skip to content

Allow newer versions of zarr package - #1968

Merged
kabilar merged 3 commits into
dandi:masterfrom
kabilar:zarr
Oct 27, 2026
Merged

kabilar merged 3 commits into
dandi:masterfrom
kabilar:zarr

Conversation

@kabilar

@kabilar kabilar commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

edit by @yarikoptic: see #1968 (comment) below

@kabilar
kabilar requested a review from CodyCBakerPhD October 27, 2026 19:39
@kabilar kabilar self-assigned this Oct 27, 2026
@kabilar kabilar added patch Increment the patch version when merged dependencies Update one or more dependencies version labels Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (e4647a6) to head (921558b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   90.82%   90.88%   +0.06%     
==========================================
  Files          92       92              
  Lines       14190    14190              
==========================================
+ Hits        12888    12897       +9     
+ Misses       1302     1293       -9     
Flag Coverage Δ
unittests 90.88% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to act in clear consciousness requires review of why we had that ceiling to start with and add that to PR description. I recall that there were dances in similar "let's just change it" cases which had ramifications. May be the comment above should reflect that ceiling!

@CodyCBakerPhD

Copy link
Copy Markdown
Contributor

As I recall the more meaningful piece was always numcodecs (which caused more of the issues historically), not the zarr upper bound itself

Should we just relax to accept w/e loose upper bound?

🤖 AI below 🤖

The risk is low and the green CI is meaningful.

Where the ceiling came from

There was never a known zarr breakage behind the ceiling.

Each time, it was set to whatever zarr release was newest when the PR was opened:

When PR Change Why
2025-06-17 #1653 (kabilar) zarr ~= 2.10 → >= 2.10, <= 3.0.8 Unblock zarr v3 for another project. 3.0.8 was the latest release. The only discussion was about adding numcodecs < 0.16 (since removed).
2026-01-29 #1779 (kabilar) <= 3.0.8 → <= 3.1.5 3.1.5 was the latest. yarikoptic flagged zarr 3.1.x breaking changes and floated excluding 3.1.1, but merged since the CI failures were unrelated.
2026-08-04 96be4a8 (yarikoptic) floor 2.10 → 2.18.0 Floor only; the ceiling stayed. The comment above the pin explains the floor, but nothing explains the ceiling.
2026-10-27 #1968 <= 3.1.5 → <= 3.4.2 3.4.2 is the latest release (published the same day).

🤖 Generated with Claude Code

https://claude.ai/code/session_01DQrzw3wdzKwrz1CxTooZum

Comment thread pyproject.toml Resolved
That is how we typically ceil if `~=` can't be used as spanning multiple majors etc

@yarikoptic yarikoptic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no side effects from my pushed ceiling - can be merged

@kabilar
kabilar merged commit e65abd3 into dandi:master Oct 27, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update one or more dependencies version patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants