Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7348 +/- ##
========================================
Coverage 95.04% 95.04%
========================================
Files 619 618 -1
Lines 52012 51762 -250
Branches 9450 9403 -47
========================================
- Hits 49434 49197 -237
+ Misses 2031 2022 -9
+ Partials 547 543 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dvd233
marked this pull request as ready for review
October 5, 2026 18:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject forbidden ASCII control characters while skipping TOML comments. The scanner now throws
SyntaxErrorat the offending character for U+0000–U+0008, U+000B–U+001F, and U+007F. LF and CRLF still terminate comments; a bare CR is rejected.The six-line production change preserves TAB, ordinary Unicode, EOF comments, hashes and existing escape handling in strings, and
skipComments: false. Scanner and public-parser regression tests cover rejection, error location, and these preserved behaviors. Removing the comment-control ignore prefix enables all six existinginvalid/control/comment-*fixtures.This addresses one comment-validation defect tracked by #6663. It is partial progress on that issue and is independent of the multiline-closing-quotes fix in #7347.
Validation
deno task okpassed in the isolated fork validation run, using the unchanged comment-only source plus a separate validation workflow.AI assistance was used for implementation, tests, review, and this PR description.