fix: return remote context download errors

[TanvirTian]

Summary

This PR fixes docker build ignoring remote context download errors by returning the error immediately instead of continuing the build.

• fixes docker build ignores remote context download errors #7372

A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cli/command/image/build.go	50.00%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[thaJeztah]

Thanks for contributing! Code changes look good, but I left a minor comment.

Can you also update your DCO sign-off to use your real name, not your GItHub handle?

Signed-off-by: TanvirTian <beachpilis@gmail.com>

(The LinkedIN profile on your account says "Tanvir Ahmed Tian", so probably "Tanvir Tian" ?)

You can change this setting in your GitHub settings as well so that it's done automatically next time you open a PR.

When updating, please amend the commit, and not push it as a second commit (so that it doesn't have to be squashed afterwards).

[thaJeztah]

Minor nit; could you move this tests further up, so that it's before the fakeBuild utility? That keeps the tests together and the (shared) utility not landing in some random place half-way in the file;

cli/cli/command/image/build_test.go

Line 175 in 02fbbf3

type fakeBuild struct {

When updating, can you also add a brief description to the test? In this case it's probably obvious from the test, but having a short reminder what it was originally for can be useful if the test evolves over time, and (in some cases) have lost its purpose.

// TestRunBuildRemoteContextDownloadError verifies that remote context
// download errors are propagated.
//
// regression test for https://github.com/docker/cli/issues/7372

[TanvirTian]

all done 🐈

[thaJeztah]

LGTM