Skip to content

INTER-2472: Update schema URL in sync script - #292

Merged
erayaydin merged 3 commits into
mainfrom
chore/openapi-repo-rename-inter-2472
Sep 29, 2026
Merged

INTER-2472: Update schema URL in sync script#292
erayaydin merged 3 commits into
mainfrom
chore/openapi-repo-rename-inter-2472

Conversation

@erayaydin

@erayaydin erayaydin commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so sync.sh will start failing with a 404. This PR changes the default OpenAPI schema url.

Alongside the URL change, the base URL moves into defaultBaseUrl with schemaUrl / examplesBaseUrl positional overrides.

@erayaydin
chore: update schema URL in sync script
5bf28d2 
Update OpenAPI schema URL in the sync script. Extract the base URL
into `defaultBaseUrl` with positional overrides.

Related-Task: INTER-2472
@erayaydin erayaydin self-assigned this Sep 24, 2026
@changeset-bot

changeset-bot Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 58bbbaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@erayaydin
erayaydin requested a balanced review from Copilot September 24, 2026 17:36
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 98.25% 168/171
🟢 Branches 97.03% 98/101
🟢 Functions 100% 37/37
🟢 Lines 98.21% 165/168

Test suite run success

132 tests passing in 30 suites.

Report generated by 🧪jest coverage report action from 58bbbaa

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.24 97.02 100 98.21
🟢  src 98.54 98.76 100 98.51
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 360,364
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 14

Copilot AI reviewed Sep 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Merging must remain coordinated with the still-open upstream PR #480 and repository rename.

Review effort: Balanced
Findings: None

What changed in this PR

Updates schema synchronization URLs for the planned OpenAPI repository rename.

Changes:

  • Uses the renamed GitHub Pages base URL.
  • Adds positional schema and examples URL overrides.
File Description
sync.sh Configures default and overridable download URLs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@erayaydin
chore: harden and tidy the sync script
21508f2 
Use `env bash` shebang, so the script picks up bash from the correct
environment. Resolve paths relative to the repository root. Harden `curl`
with retry transient failures, refuse redirects that leave https and
bound connect and transfer time so a stalled download cannot hand CI or
local. Rename `examplesList` to `examples`, log the full URL being
fetched rather than just the example path, so it is clear which base URL
a run actually used.

Related-Task: INTER-2472
@erayaydin
chore: rename baseDestination to exampleBaseDestination
58bbbaa
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/node-sdk@7.7.2

Patch Changes

  • Throw SdkError instead of TypeError or Error for invalid API client arguments. (fde9447)

@erayaydin
erayaydin marked this pull request as ready for review September 25, 2026 09:02
@erayaydin erayaydin changed the title [DO NOT MERGE] INTER-2472: Update schema URL in sync script INTER-2472: Update schema URL in sync script Sep 29, 2026
@erayaydin
erayaydin merged commit e573167 into main Sep 29, 2026
19 checks passed
@erayaydin
erayaydin deleted the chore/openapi-repo-rename-inter-2472 branch September 29, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mcnulty-fp mcnulty-fp mcnulty-fp approved these changes
@Orkuncakilkaya Orkuncakilkaya Awaiting requested review from Orkuncakilkaya Orkuncakilkaya is a code owner
@JuroUhlar JuroUhlar Awaiting requested review from JuroUhlar JuroUhlar is a code owner
@ilfa ilfa Awaiting requested review from ilfa ilfa is a code owner
@makma makma Awaiting requested review from makma makma is a code owner

Assignees

@erayaydin erayaydin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erayaydin @mcnulty-fp