Repository navigation
revert: move the post-GA commits to version-10.0.1 - #2552
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the 'Professional' theme customization and simplifies the custom theme implementation in the FirebaseUI Auth demo app, while updating dependencies to version 10.0.0-beta05 and revising the documentation to reflect the beta release. Feedback on the changes highlights several issues: a potential silent failure when updating passwords if the current user is null, typos introduced in exception messages, and multiple instances of hardcoded Color.White that break dark mode support in text fields and surfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the three commits merged after the 10.0.0 tag so master matches the 10.0.0 release again. They move to
version-10.0.1and come back through a PR from that branch.Changes
AuthExceptionmessage typo fixes, version string bump).10.0.0tag (478106d).