Repository navigation
Update datastore.go - #55072
Update datastore.go#55072
Conversation
Changed 3 error messages that said "team" to use "fleet" instead.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughSecret-use deletion errors now refer to the owning scope as a fleet instead of a team. The errors cover scripts, host-name templates, and configuration profiles. For unassigned scripts, Apple configuration profiles, Apple declarations, and Windows configuration profiles, the reported name changes from “No team” to “Unassigned.” Possibly related issues
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title refers to a modified file and is related to the pull request, but it does not describe the wording changes. It is still sufficiently related to pass. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The description gives a clear reason for the change: "fleets" were formerly called "teams", so three error messages now say "fleet" and "No team" now says "Unassigned". It states that tests asserting … Full details: Description check
-
Explanation
The description gives a clear reason for the change: "fleets" were formerly called "teams", so three error messages now say "fleet" and "No team" now says "Unassigned". It states that tests asserting the old wording were updated. The changes file, input validation, automated tests, and manual QA items are checked, and a screenshot section is present. The AI section follows the template format. Gaps: the 'Related issue' line still shows the placeholder 'Resolves #' with no issue number. The description also does not name the specific error messages or the files changed. Several template sections (load testing, GitOps, Apple MDM, database migrations, fleetd) were left unaddressed, but these do not apply to a wording change, and the template allows non-applicable items to be deleted. The description is mostly complete.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
I will get screenshots and attach later if needed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55072 +/- ##
==========================================
+ Coverage 77.54% 77.55% +0.01%
==========================================
Files 4347 4347
Lines 271675 271675
Branches 15961 16000 +39
==========================================
+ Hits 210678 210707 +29
+ Misses 60811 60783 -28
+ Partials 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @patrickrgr! If possible please fix the failing test (now failing because of string comparison in the error) |
|
Thanks for the contribution, @patrickrgr! |
There was a problem hiding this comment.
🟢 Approval recommended
The terminology-only changes are consistent with the updated test assertions and introduce no identified correctness issues; tests were not executed.
No open issues 🎉
What changed in this PR
Updates secret-variable deletion errors to use Fleet’s current terminology without changing deletion logic.
Changes:
- Replaces “team” with “fleet” in errors for scripts, host name templates, and configuration profiles.
- Changes the unassigned-group label from “No team” to “Unassigned.”
- Updates datastore and integration test expectations to match.
| File | Description |
|---|---|
server/service/integration_core_secret_variables_test.go |
Updates expected user-facing deletion errors. |
server/fleet/datastore.go |
Uses “fleet” in three secret-use error messages. |
server/datastore/mysql/secret_variables.go |
Uses “Unassigned” for missing team names. |
server/datastore/mysql/secret_variables_test.go |
Updates expected unassigned-group labels. |
Review effort: Balanced
Resolves: #56414.
If I understand correctly, "fleets" used to be called "teams".
Changed 3 error messages that said "team" to use "fleet" instead.
Also changed "No team" to "Unassigned" in these messages, and updated the tests that asserted the old wording.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing
AI
AI: Claude Code (claude-opus-5-5)
Frontend