[yeoldegrove]

What this PR does / why we need it:

Code refactoring

glrd/git.py — replace gh/git CLI with python-gardenlinux-lib

Use gardenlinux.github.Client (PyGithub) and gardenlinux.git.Repository
(pygit2) instead of subprocess calls to gh and git. Both are already
pulled in transitively by the gardenlinux dependency.

• get_github_releases: Client().get_repo(...).get_releases()
• get_git_commit_from_tag: get_git_ref() with annotated-tag dereferencing
• get_git_commit_at_time: Repository.checkout_repo() + pygit2 walk
• cleanup_temp_repo: replace tempfile.mkdtemp + manual shutil.rmtree with tempfile.TemporaryDirectory; dereference _repo_instance before cleanup

Auth change: GITHUB_TOKEN is now required for GitHub API calls instead
of gh auth login. Remove gh CLI install from Containerfile.

release.py — single source of truth, split into one class per file

• Harden Version for 'next' sentinel; make to_dict faithful
• Wire as SSoT in query.py (filter, sort, latest, active/archived) and
  manage.py (create, parse_release_name, ensure_isodate_and_timestamp)
• Add Release.default_name() and Release.github_release_url()
• Split into canonical submodules: release_type.py, version.py,
  lifecycle.py, git_info.py, release_model.py, release_collection.py,
  release_name.py; all callers updated to import directly from the
  canonical module

manage.py — remove duplicates

Remove functions now imported from git.py, validation.py, and s3.py.
Remove unused imports. Replace if/elif/else chain on rtype with a
match statement.

schema.py — unify schema_v1.py and schema_v2.py

Generate SCHEMA_V1 and SCHEMA_V2 from shared builder functions.
Reduces of duplicated definitions. Delete schema_v1.py and
schema_v2.py.

Other refactors

• Extract validation functions to glrd/validation.py
• Extract S3 operations to glrd/s3.py
• Extract shared helpers into glrd/util.py (V2_SCHEMA_THRESHOLD,
  split_releases_by_type now returns a typed ReleasesByType dataclass,
  run_subprocess, parse_isodatetime, fatal_error, resolve_flavors,
  merge_input_data)
• Bump python-gardenlinux-lib dependency from 0.6.0 to 0.10.24.
• Fix circular import: move merge_input_data from manage to util
• Fix filter_releases crash on unknown --type values
• Add --no-flavors flag and GLRD_SKIP_FLAVORS env var
• Add --input-type/--input-url/--input-file-prefix/--query-input-format
  to glrd-manage for offline/custom-source queries
• Fix deprecated datetime.utcfromtimestamp() usage throughout

glrd/util.py + glrd/query.py — split CONTAINER_REGISTRY by release type

• Rename DEFAULTS['CONTAINER_REGISTRY'] → DEFAULTS['CONTAINER_REGISTRY_MINOR']
  (ghcr.io/gardenlinux/gardenlinux)
• Add DEFAULTS['CONTAINER_REGISTRY_NIGHTLY'] (ghcr.io/gardenlinux/nightly)
• Add get_container_registry(release_type) helper in query.py that returns
  the nightly registry for nightly releases and the minor registry otherwise
• Thread release_type through prepare_oci_flavor_url (new 4th param) and
  its call site in format_flavors_with_urls
• Update get_oci_url to use get_container_registry(release.get('type'))

Tests

• Make full test suite fully offline (was hanging on network before) via autouse conftest fixture
• Add tests/test_git.py: unit tests for all git.py functions, mocking
  gardenlinux.github.Client and using a local pygit2 bare-repo fixture;
  includes cache-reuse and error-path cleanup assertions for TemporaryDirectory
• Add tests/test_release_model.py: unit tests for the release model, updated
  to import directly from canonical submodules
• Add tests/test_util.py: unit tests for split_releases_by_type /
  ReleasesByType (empty input, per-type routing, unknown/missing type dropped,
  multiple same-type, field independence)
• Add offline CLI integration tests (active/archived/latest/version
  filter, no-flavors, unknown-type guard)
• Add tests/test_query_oci.py: unit tests covering get_container_registry,
  get_oci_url, and prepare_oci_flavor_url for both container and bare flavors
• Add OCI integration tests to test_integration.py: nightly registry selection,
  minor registry selection, and cross-type registry difference

Documentation

• Replace monolithic docs/overview/README.md with a full Diataxis
  structure: reference/index.md, reference/cli.md, reference/schema.md,
  explanation/release-lifecycle.md, how-to/index.md, how-to/run-glrd.md,
  how-to/query-releases.md, how-to/manage-releases.md
• Replace gh CLI prerequisite in run-glrd.md with GITHUB_TOKEN
  prerequisite; add GITHUB_TOKEN callout to manage-releases.md

Fixes

Fixes #16
Fixes #14
Fixes #4

[gardenlinux-docs-bot]

📚 Documentation Preview PR: gardenlinux/docs#132
😎 Deploy Preview: https://deploy-preview-132--gardenlinux-docs.netlify.app

A PR has been created/updated to preview the documentation changes from this PR.

[NotTheEvilOne]

You can use gardenlinux.DistroVersion here which extends semver.Version. This provides the same functionality to create and count up version numbers semver compliant.

[yeoldegrove]

@NotTheEvilOne I looked at gardenlinux.DistroVersion and couldn't really see how GLRD would benefit from using it. We're doing way more complex things by using jsonschema dicts and comparing those.
Maybe at some point in time the whole version schema logic/code could go into the python lib.

If you still think it's a good idea to use gardenlinux.DistroVersion, I would need a hint where exactly.

[NotTheEvilOne]

I was thinking of using this class for calculating one version from another one. See python-gardenlinux-lib tests and the underlying semver API.

[yeoldegrove]

@NotTheEvilOne Addressed your comments, please re-review.

[NotTheEvilOne]

LGTM even thought I think additional code changes may further improve readability of the code.