Repository navigation
perf(ci): minimize Playwright system dependency installation - #26159
Merged
nicohrubec merged 5 commits intoNov 6, 2026
Merged
nicohrubec merged 5 commits into
nicohrubec merged 5 commits into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
changed the title
Contributor
size-limit report 📦Compared: ccce20b (PR test merge using feat/benchmark-arm-integrations at b794886) Against: f2ee787 (feat/benchmark-arm-integrations) · base run #65001
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 50 successful. See the run.
Successful checks
|
nicohrubec
marked this pull request as ready for review
November 6, 2026 07:56
nicohrubec
requested review from
isaacs,
logaretm,
msonnb,
mydea and
s1gr1d
and removed request for
a team
November 6, 2026 07:57
andreiborza
approved these changes
Nov 6, 2026
chargome
approved these changes
Nov 6, 2026
Comment on lines
+53
to
+67
| sudo apt-get install -y --no-install-recommends \ | ||
| gstreamer1.0-plugins-base \ | ||
| gstreamer1.0-plugins-good \ | ||
| libavif16 \ | ||
| libevent-2.1-7t64 \ | ||
| libflite1 \ | ||
| libgles2 \ | ||
| libgstreamer-gl1.0-0 \ | ||
| libgstreamer-plugins-bad1.0-0 \ | ||
| libgstreamer-plugins-base1.0-0 \ | ||
| libharfbuzz-icu0 \ | ||
| libhyphen0 \ | ||
| libmanette-0.2-0 \ | ||
| libopus0 \ | ||
| libwayland-server0 |
nicohrubec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Many of our CI runs today stall a long time waiting to install ubuntu system dependencies for browsers getting installed during the playwright installation step. Turns out, many of these system requirements are already preinstalled by the GitHub runners we use. In fact, for firefox and chromium ALL for us required system packages are already on the runner and running the system dependency installation step only adds bloat, e.g. font packages that we do not need for our tests. For webkit it's not as easy, but we can still hand-install a subset of the dependencies and significantly reduce the total download size. We get good per job savings:
Since this runs on hundreds of browser/E2E test jobs in our CI, we save around 6GB of downloads in one full CI run drastically reducing the likelihood of hitting a slow download mirror.