Repository navigation
ref(tracing): Document Span::setMetricsSummary value type to drop PHPStan baseline entry - #2362
Merged
Merged
Conversation
…Stan baseline entry
sentry-junior
Bot
requested review from
a team and
stayallive
as code owners
November 13, 2026 15:08
Litarnus
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes this entry from
phpstan-baseline.neon:This adds
@param string|int|float $valueto the deprecated no-opSpan::setMetricsSummary(). That's the type the method had when it was introduced in #1619, and the docblock lost it when the metrics API became a no-op.It only changes a docblock on a method with an empty body, so there's no runtime or public API change. PHPStan reports no errors, Mago reports no new issues, and the
tests/Tracingsuite passes.The
$tagsentry for the same method is left for a separate PR so each change stays one baseline entry.via automation
sched_a59acc45df166a80a839d0b32321e740· Run IDsched_a59acc45df166a80a839d0b32321e740:1794582238204.--
View Session [Sentry]