Repository navigation
ref(notebooks): Let the update validator archive or update a notebook - #130824
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
billyvg
approved these changes
Nov 12, 2026
wedamija
force-pushed
the
danf/notebooks-public
branch
from
November 13, 2026 18:37
9ca5197 to
e573180
Compare
wedamija
force-pushed
the
danf/notebooks-details-put-validator
branch
from
November 13, 2026 18:37
238dace to
defcdb4
Compare
Contributor
Sentry Snapshot Testing
|
wedamija
force-pushed
the
danf/notebooks-public
branch
from
November 13, 2026 19:15
e573180 to
91ebb4b
Compare
wedamija
force-pushed
the
danf/notebooks-details-put-validator
branch
from
November 13, 2026 19:15
defcdb4 to
65db876
Compare
wedamija
force-pushed
the
danf/notebooks-public
branch
from
November 13, 2026 22:37
91ebb4b to
8fcfa93
Compare
wedamija
force-pushed
the
danf/notebooks-details-put-validator
branch
from
November 13, 2026 22:37
65db876 to
51eb023
Compare
wedamija
force-pushed
the
danf/notebooks-public
branch
from
November 13, 2026 23:30
8fcfa93 to
d3f754e
Compare
wedamija
force-pushed
the
danf/notebooks-details-put-validator
branch
from
November 13, 2026 23:30
51eb023 to
57e346d
Compare
wedamija
force-pushed
the
danf/notebooks-public
branch
from
November 13, 2026 23:43
d3f754e to
5227fe3
Compare
NotebookUpdateValidator.save() picks archive or update from the validated fields, so the details endpoint PUT doesn't branch on the payload.
wedamija
force-pushed
the
danf/notebooks-details-put-validator
branch
from
November 14, 2026 01:12
57e346d to
21b4b68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're moving the notebook tables (Investigation*) into a new
sentry.notebooksapp, separate from the hypothesis engine that writes them, so other Seer producers like Autofix and triage can write notebooks too.NotebookUpdateValidator.save() picks archive or update from the validated fields, so the details endpoint PUT doesn't branch on the payload. Responses don't change.