Repository navigation
Add --no-clobber for explicit --output files - #2341
Open
VISHNU0906 wants to merge 1 commit into
Open
VISHNU0906 wants to merge 1 commit into
VISHNU0906 wants to merge 1 commit into
Conversation
Opt-in flag fails without changing an existing destination, including symlinks, by opening the output path with O_EXCL. Rejected without --output or with --in-place; default overwrite behavior is unchanged. Fixes getsops#2297 Signed-off-by: KVR Vishnu <46535652+VISHNU0906@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
--no-clobberflag sosopsfails instead of overwriting an existing--outputdestination (including through symlinks). Default overwrite behavior stays the same.Why
Requested in #2297 for safer scripted decrypt/encrypt flows.
Test plan
--output, reject with--in-place, existing file, symlink target, and successful write into a new path.go test ./...on the touched packages.Fixes #2297
Supersedes #2340 (same change, recommitted with DCO sign-off).