Skip to content

Minor VSCode workspace settings changes - #4197

Merged
mbg merged 2 commits into
mainfrom
mbg/vscode/workspace-improvements
Oct 5, 2026
Merged

mbg merged 2 commits into
mainfrom
mbg/vscode/workspace-improvements

Conversation

@mbg

@mbg mbg commented Oct 5, 2026

Copy link
Copy Markdown
Member

Two small changes:

  • One of the existing keys is deprecated. It is replaced with the new replacement key.
  • Added the "tests" folder to the excluded paths. This contains a number of language-specific integration tests. The reason for excluding it from the workspace by default is because some language-specific VSCode extensions will detect files in that directory and start up automatically even if none of the files are opened. That adds start-up time, runs unnecessary background processes, and some of the extensions complain rather loudly that the test projects don't meet their expectations. Unfortunately, there's no way to disable the extensions (if installed) for the workspace in a configuration file.

@mbg
mbg requested a review from a team as a code owner October 5, 2026 10:20
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:20
@github-actions github-actions Bot added the size/XS Should be very easy to review label Oct 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The settings changes are valid and focused, with only a non-blocking wording correction noted.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates workspace defaults to reduce unnecessary extension activation and use the current VS Code TypeScript SDK setting.

Changes:

  • Excludes integration-test fixtures from the workspace.
  • Replaces the deprecated TypeScript SDK key.
File Description
.vscode/​settings.json Updates workspace exclusions and TypeScript SDK configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .vscode/settings.json
"build": true,
"lib": true,

// exclude "tests" by default because it causes VSCode to start language-specific extensions
@mbg
mbg enabled auto-merge October 5, 2026 10:27
@mbg
mbg added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit aeafd00 Oct 5, 2026
234 checks passed
@mbg
mbg deleted the mbg/vscode/workspace-improvements branch October 5, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants