Repository navigation
Fix CI with standard macOS runners and update brace-expansion - #4320
beer-sakthai wants to merge 7 commits into
Conversation
…in-n5m9pm Sync main with upstream github/codeql-action
The `*-xlarge` macOS runners are GitHub larger runners that are not available to this fork, so every job targeting them failed without starting. Switch to the standard hosted equivalents (macos-latest, macos-15, macos-14) in the PR-check sources and codeql.yml, and regenerate the PR-check workflows with pr-checks/sync.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6REV1f9XMQdyBtTufzb8e
This fork has CodeQL default setup enabled, which rejects SARIF from advanced configurations, so the `analyze-javascript (ubuntu-24.04)` and `analyze-other` jobs failed at upload. Default setup already scans this repository, so keep running the analyses but only upload when running in github/codeql-action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6REV1f9XMQdyBtTufzb8e
…in-n5m9pm Fix fork CI: standard macOS runners and skip self-analysis uploads
Bumps the npm_and_yarn group with 1 update in the / directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `brace-expansion` from 1.1.18 to 1.1.21 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.18...v1.1.21) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn-cb24140fdc Bump brace-expansion from 1.1.18 to 1.1.21 in the npm_and_yarn group across 1 directory
There was a problem hiding this comment.
🟡 Changes recommended
The CodeQL workflow’s repository check still allows fork pull requests to attempt SARIF uploads with a fork-restricted token, so the guard needs to be corrected to include the pull request’s source repository.
1 open issue
What changed in this PR
Updates CI to use standard macOS GitHub-hosted runners, synchronizes generated workflows, refreshes transitive brace-expansion dependencies, and adjusts CodeQL SARIF upload conditions.
Changes:
- Replaced macOS xlarge runner labels with standard
macos-14,macos-15, andmacos-latestlabels. - Updated the Xcode 16 selection condition for the macOS 15 runner.
- Refreshed
brace-expansionentries and integrity metadata in the lockfile. - Added a canonical-repository guard around CodeQL SARIF uploads.
| File | Description |
|---|---|
| pr-checks/checks/swift-custom-build.yml | Uses the standard macOS runner for Swift custom-build checks. |
| pr-checks/checks/swift-autobuild.yml | Uses the standard macOS runner for Swift autobuild checks. |
| pr-checks/checks/per-language-bundle-validation.yml | Uses the standard macOS runner for Swift bundle validation. |
| pr-checks/checks/multi-language-autodetect.yml | Updates macOS runner labels and the Xcode 16 selection condition. |
| pr-checks/checks/all-platform-bundle.yml | Uses the standard macOS runner for all-platform bundle checks. |
| package-lock.json | Refreshes transitive brace-expansion package versions and integrity metadata. |
| .github/workflows/codeql.yml | Updates the macOS analysis matrix and CodeQL SARIF upload condition. |
| .github/workflows/__swift-custom-build.yml | Synchronizes the generated workflow with the standard macOS runner change. |
| .github/workflows/__swift-autobuild.yml | Synchronizes the generated workflow with the standard macOS runner change. |
| .github/workflows/__per-language-bundle-validation.yml | Synchronizes the generated workflow with the standard macOS runner change. |
| .github/workflows/__multi-language-autodetect.yml | Synchronizes the generated workflow with the runner and Xcode selection updates. |
| .github/workflows/__all-platform-bundle.yml | Synchronizes the generated workflow with the standard macOS runner change. |
Review effort: Lite (auto)
beer-sakthai
left a comment
There was a problem hiding this comment.
Review completed. Before release, please ensure the stated risk level matches the production code paths affected, appropriate validation has been completed, and rollback/monitoring coverage is in place. Also confirm backwards compatibility and whether a changelog or documentation update is required.

Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist