Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
unified/callable-ex
branch
from
September 29, 2026 14:09
c4c1d44 to
af8addb
Compare
| private import codeql.unified.internal.CallableExPluginSwift | ||
| } | ||
|
|
||
| /** Extension point for language-specific inputs to `CallableEx.qll`. */ |
hvitved
force-pushed
the
unified/callable-ex
branch
2 times, most recently
from
September 30, 2026 12:25
9a3ae2b to
00344d0
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Constructor synthesis mishandles protocol conformances, convenience initializers, and static struct properties.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Introduces unified abstractions for source and synthesized callables, parameters, default constructors, and inherited constructors.
Changes:
- Adds
CallableExandParameterExabstractions. - Adds Swift-specific constructor synthesis rules.
- Adds Swift constructor fixtures and query expectations.
| File | Description |
|---|---|
CallableEx.qll |
Implements extended callable and parameter modeling. |
CallableExPlugin.qll |
Defines language-specific extension points. |
CallableExPluginSwift.qll |
Supplies Swift constructor synthesis rules. |
constructors.swift |
Adds Swift constructor test fixtures. |
test.ql |
Queries synthesized constructors and parameters. |
test.expected |
Records generated query expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
force-pushed
the
unified/callable-ex
branch
from
September 30, 2026 12:58
00344d0 to
2b8bcc0
Compare
hvitved
force-pushed
the
unified/callable-ex
branch
2 times, most recently
from
September 30, 2026 13:15
389fd3a to
4b6b368
Compare
hvitved
force-pushed
the
unified/callable-ex
branch
from
September 30, 2026 17:48
4b6b368 to
3bc691f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
CallableExandParameterExin order to have shared logic for default/inherited constructors and implicit receiver parameters. I am working on a follow-up PR that makes use of these in type inference.