Unified: Implement ClassLikeDeclaration.toString - #22698
Merged
Merged
Conversation
asgerf
approved these changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Extensions stringify without their target type, making distinct extensions indistinguishable.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Implements readable string representations for unified class-like declarations.
Changes:
- Derives declaration kind and name in
ClassLikeDeclaration.toString. - Updates generated control-flow expectations.
| File | Description |
|---|---|
FacadeAst.qll |
Adds class-like declaration formatting. |
basicblock-slices.expected |
Updates generated labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| result in ["class", "struct", "interface", "enum", "actor", "extension", "protocol"] | ||
| } | ||
|
|
||
| override string toString() { result = concat(this.getKind() + " ") + concat(this.getName()) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.