[CI signal only, do not merge] Canonical runtime src/sdk at 8575ea4f - #2773
Draft
gokhanarkan wants to merge 7 commits into
Draft
gokhanarkan wants to merge 7 commits into
gokhanarkan wants to merge 7 commits into
Conversation
| var property = type.GetProperty(name); | ||
| Assert.NotNull(property); | ||
| Assert.Contains(property.CustomAttributes, attribute => | ||
| attribute.AttributeType.FullName == "System.Runtime.CompilerServices.RequiredMemberAttribute"); |
| foreach (var name in new[] { nameof(McpPlanInstallRequest.Scope), nameof(McpPlanInstallRequest.PolicySessionId) }) | ||
| { | ||
| Assert.DoesNotContain(typeof(McpPlanInstallRequest).GetProperty(name)!.CustomAttributes, attribute => | ||
| attribute.AttributeType.FullName == "System.Runtime.CompilerServices.RequiredMemberAttribute"); |
| Contract = null!, | ||
| Source = new McpPlanInstallSourceCandidate { CandidateHandle = "candidate", SearchId = "search" }, | ||
| })); | ||
| await Assert.ThrowsAsync<ArgumentNullException>(() => client.Rpc.Mcp.PlanInstallAsync((McpPlanInstallRequest)null!)); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI signal only. Do not merge. This draft exists so CI can run on the reconciled canonical SDK before a real release. It must never be merged into
main. The real export happens only through the runtime release workflow (publish-cli.yml, jobsdk-release-snapshot) when a CLI version that contains this source ships.Source
26fb2b0e,src/sdksubtreedd47a887). This is the head of github/copilot-agent-runtime#22809, which merges github/copilot-agent-runtime#22802 (so it includes github/copilot-agent-runtime#22786 and current runtimemain).mainat4001c1da("Update SDK snapshot for Copilot CLI 1.0.89-3").How it was produced
The release tool is
script/sdk-release-snapshot.ts. I didn't use its own dry run:runSnapshot()refuses a--versionequal to the released version when the tree differs (line 161), and a newer version would invent pins. So a local, uncommitted driver repeatsrunSnapshot()step by step:maingit rm -r -q --ignore-unmatch .git archive --format=tar HEAD:src/sdkfrom the runtime committar -xfupdateVersionPins(), given the released version1.0.89-3(read frommain)git add -AThe driver stops before the commit and push. Command:
This isn't hand copying, and no workflow was dispatched. The runtime
src/sdkhas noexport-ignoreorexport-substattributes, sogit archivefilters nothing, exactly as in the release job. The one symlink,rust/LICENSE, is preserved.What differs from
mainThe tree equals the runtime
src/sdksubtree byte for byte, exceptnodejs/package.jsonandnodejs/src/cliVersion.ts. Those two keepmain's released pins (copilotCliVersion/COPILOT_CLI_VERSION=1.0.89-3), so there's no0.0.0-devpin and no invented pin. Other0.0.0-devpackage versions are unchanged frommain.Compared with
main, the diff now spans the files listed on this PR. This branch was first exported from runtime1e15bb8fand refreshed by a normal fast-forward push. Refreshes so far:main: github/copilot-agent-runtime#22578's Dynamic Workflows rename, which intentionally removes the experimentalFactory*surface (rpc.factorybecomesrpc.workflow); github/copilot-agent-runtime#22558's projections; github/copilot-agent-runtime#22211'sModelChangeSourcevalueauto_tier_recommendationand optionalautoTieron the SetModel slash-command result, in all six SDKs; and the synced SDK workflow updates;x-legacy-parametersprojection from github/copilot-agent-runtime#22786 and github/copilot-agent-runtime#22802 (published request types keep their shape, with new inputs on extensibleOptions/request overloads per language); Rust compatibility aliases keeping every released 1.0.89-3 type name;McpInstallPlan.transportChoiceskept at its released Rust shape viax-legacy-untyped;McpServer.owned(McpServerOwnership) with responsex-legacy-parametersprojections; a back-compatible Rust fix soAttachmentGitHubReference/PushAttachmentGitHubReferenceserialise their"github_reference"type literal instead of"Unknown";McpInstallationReviewaction literal its own enum, so uninstall reviews deserialise, with a generator guard against enum-name collisions; thelarge_futures-safesession_test;rust/src/router.rsno longer awaitsextensionLaunchProvider.resolveon the request loop) and their Rust and Node regression tests, including a hungllmInferencecase. The main changes:installations.confirmreceivers and their tests and fixturesmcp.prepareInstall/applyInstall/planUninstall/applyUninstall,mcp.installations.*,session.mcp.oauth.prepareLogin/cancelLoginand theexpectedInstallationIdguardssdk-consistency-reviewworkflow files, as runtimemainalready didThe only manifest change is a new
installation_confirmation_testtarget inrust/Cargo.toml.Expected failures
The released CLI
1.0.89-3doesn't implement the runtime-new methods above. Tests that run against the released CLI, such as the RPC inventory and E2E suites exercising those methods, are expected to fail by design. That's a version-skew signal, not a defect here. Python, Go, .NET and Java receivers forinstallations.confirmfail closed for now (github/copilot-agent-runtime#22844).