Skip to content

Preserve review provenance marker for supersede-older-reviews #63264

Closed

Description

@lxghtless

Problem

submit-pull-request-review with footer: always and supersede-older-reviews: true emits a gh-aw-workflow-call-id marker in the safe-output tool call, but the marker is absent from the review body later returned by GitHub's pull-request review API. The native supersession handler therefore cannot match and dismiss an older REQUEST_CHANGES review from the same workflow.

Evidence

  • The rendered agent prompt required the marker.
  • The safe-output MCP log recorded a submit_pull_request_review body ending with:
    <!-- gh-aw-workflow-call-id: owner/repo/test-critic-review -->
  • The handler logged PR review footer mode set to "always" and PR review supersede mode enabled.
  • The created GitHub review body did not contain the marker, and the earlier blocking review remained CHANGES_REQUESTED.

Expected behavior

A review created by submit-pull-request-review retains a durable workflow-specific provenance marker that supersede-older-reviews can safely use to dismiss only older blocking reviews from the same workflow.

Suggested direction

Persist provenance outside sanitized review body content, or ensure the marker survives the safe-output/GitHub review submission path. Add an integration test that creates a blocking review, posts a clean replacement review, and asserts the old review becomes DISMISSED without affecting a different workflow's review.

Activity

  1. locked and limited conversation to collaborators on Sep 24, 2026
  2. unlocked this conversation on Sep 24, 2026
  3. lxghtless commented on Sep 24, 2026

    @lxghtless
    Author

    Additional live evidence: supersede-older-reviews runs after every submitted review event, including a new REQUEST_CHANGES, so it can dismiss an earlier same-workflow blocking review and hide unresolved findings. The framework fix needs both durable persisted provenance and an explicit clean-comment-only supersession condition; the affected repository has disabled automatic supersession until then.

  4. locked and limited conversation to collaborators on Sep 24, 2026
  5. unlocked this conversation on Sep 24, 2026
  6. pelikhan commented on Sep 26, 2026

    @pelikhan
    Collaborator

    @lxghtless do you have an example of such filtering?

  7. pelikhan commented on Oct 1, 2026

    @pelikhan
    Collaborator

    @copilot use the suggested syntax in pr pull request review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions