Skip to content

fix: stabilize account scopes icon components - #3393

Merged
setchy merged 1 commit into
mainfrom
fix-inline-scopes-icon
Oct 8, 2026
Merged

setchy merged 1 commit into
mainfrom
fix-inline-scopes-icon

Conversation

@setchy

@setchy setchy commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the inline Accounts scopes icon component with stable module-level recommended/alternate wrappers and the existing uncolored shield fallback.
  • Preserve SVG colors, recommended-scope precedence, button variants, visibility, accessibility, and navigation.
  • Add nine regression tests for scope states, SVG retention across unrelated rerenders, and updated-account navigation after scope changes.

Addresses SonarCloud rule typescript:S6478, issue AaEEOx08BWAt1Ywq9D_I. Other SonarCloud findings are outside this PR.

Validation

  • pnpm check passed.
  • pnpm exec tsc --noEmit --incremental false passed.
  • Focused Accounts/authentication-scope tests: 48 passed.
  • Full unit suite: 1,865 tests passed across 186 files.
  • Pre-commit formatting, lint, type checks, and changed tests passed.
  • OpenSpec strict validation passed; all four requirements and eight scenarios have implementation/test evidence.

Pending CI confirmation

  • Local visual regression could not run because Docker is not running. Use the existing Visual Regression CI job; no screenshot baselines were changed.
  • Confirm SonarCloud closes the finding after an analysis containing this fix.

OpenSpec planning artifacts remain local, consistent with the repository ignoring openspec/. No dependencies, persisted data, or scope policies changed.

@setchy
setchy requested a review from afonsojramos as a code owner October 8, 2026 22:54
@github-actions github-actions Bot added the bug Something isn't working label Oct 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@setchy
setchy merged commit a547cd8 into main Oct 8, 2026
19 checks passed
@setchy
setchy deleted the fix-inline-scopes-icon branch October 8, 2026 22:58
@github-actions github-actions Bot added this to the Release 7.10.0 milestone Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants