Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the test project on Linux (the Windows binaries were cross-compiled) this will generate a binary that is ~200-400kb smaller!
This works by inlining fewer things, moving some of the generated code into helper functions, and removing
ERR_PRINT_ONCE()fromCHECK_METHOD_BIND*()It's very similar to these PRs from @Ivorforce on the Godot repo:
Object::_get_property_list_innerto save on binary size (~400kb down) godot#124043~MethodDefinitionout of line, to save on binary space in debug binaries (~1.8mb macOS, ~600kb web) godot#124027