Repository navigation
fix(vulnfeeds): delete rejected CVEs from combined output and clean up withdrawn relations - #6314
Merged
Merged
Conversation
…p withdrawn relations
michaelkedar
approved these changes
Nov 10, 2026
munimv2
added a commit
to munimtechnologies/advisory-import-census
that referenced
this pull request
Nov 10, 2026
…6 found live? OSV.dev merged google/osv.dev#6314 on 2026-11-10, fixing google/osv.dev#6313 (study S16: every rejected 2026 CVE in the sample was still live). S17 freezes six predictions before the fix is visible, to be graded on S16's 163 live and 7 withdrawn records on or after 2026-11-17. Also adds docs/upstream-outcomes.md, a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6313.
Upstream CVE rejections (
REJECTEDin CVEList V5 /Rejectedin NVD) are converted into withdrawn tombstone records bycve5-to-osvandnvd-cve-osv(since #5761), andcombine-to-osvreturnsnilwhen either input haswithdrawnset. However,combine-to-osvruns with-sync-deletions=false(and enabling full-bucket-sync-deletionswould delete valid pre-2016 CVEs and legacy upstream stubs inosv-output/), so existinggs://cve-osv-conversion/osv-output/<CVE>.jsonrecords were never removed when a CVE transitioned toREJECTED. As a result, neitherimporternorimporter-deleterdetected the rejection and the records remained live withoutwithdrawn.Changes
vulnfeedswriter.HandleWithdrawnDeletions&writer.DeleteLocalFiles: List objects inosv-output/, intersect against CVE IDs markedwithdrawnin eithercve5ornvd, skip any record with a manual override inosv-output-overrides/, and delete matching stale objects soimporter-deletermarks themwithdrawnviaTaskDelete(without touching pre-2016 CVEs or non-withdrawn records).combine-to-osv: Collect withdrawn CVE IDs duringreadAndCombineWorkerand unconditionally clean up existing withdrawn records after uploads finish.cve5/bulk-converter: Emit withdrawn tombstones forREJECTEDCVEs even when the assigning CNA is incna_denylist.txt(sincecve5.CVEToOSVreturns early before version extraction forREJECTEDrecords).go/cmd/relationsUpdater.run(update.go): DeleteListedVulnerability(instead of unconditionallyPutting it) when updating relations on a withdrawn vulnerability, preventing withdrawn CVEs from reappearing on/list.updateAliasGroup(alias.go): Mark removedAliasGroupmembers inchangedVulnswhen a group shrinks, splits, or is deleted so surviving records have stale aliases to withdrawn duplicates cleared.Testing
vulnfeeds/conversion/writer/writer_test.go,vulnfeeds/cmd/combine-to-osv/main_test.go,vulnfeeds/cmd/converters/cve/cve5/bulk-converter/main_test.go, andgo/cmd/relations/alias_test.go.cd vulnfeeds && go test ./...passed.poetry run tools/lint_and_format.shpassed with 0 issues.