Repository navigation
feat(postgres): set up dual-writes - #6316
Open
michaelkedar wants to merge 2 commits into
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udcbd\u270d\ufe0f\u270d\ufe0f"
Open
michaelkedar wants to merge 2 commits into
michaelkedar wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Sorry this PR is so big, a lot of things ended up having to be done at the same time)
Set up dual-writing infrastructure for Postgres in the places where vulns get written:
VulnerabilityStorefor postgres (splitting thequeries.sqlinto files corresponding to the go files they're used in)raw_vulnerabilitiesandhistoric_vulnerabilitiesto be written with all needed fieldsI may have to make a follow-up PR fairly quickly to bump the CPUs of the postgres if affected commits are too plentiful.
In a future PR, I plan to re-jig the tests so they spin up postgres in a docker container instead of trying to mock all the endpoints, so we can make sure our queries actually work properly.