Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces several new generated services to the Google Cloud Compute C++ SDK, specifically global_frontend_settings, image_views, managed_rulesets, and project_views. This includes the generation of clients, connections, REST stubs, mocks, and samples for these services, alongside updates to environment variables and documentation. The review feedback highlights style guide violations in the generated code, specifically the use of default parameters within internal namespaces in GlobalFrontendSettingsRestMetadata and the use of auto type deduction obscuring a StatusOr return type in the client samples. These issues should be addressed by updating the code generator rather than modifying the generated files directly.
|
/gcbrun |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16483 +/- ##
==========================================
- Coverage 92.35% 92.33% -0.03%
==========================================
Files 2258 2258
Lines 216448 216448
==========================================
- Hits 199909 199848 -61
- Misses 16539 16600 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a9cc8e4 to
aebdd44
Compare
|
/gcbrun |
Automated update of Compute Engine Discovery Document and generated C++ client code.
Triggered automatically by the
update-compute-discoveryworkflow.