Skip to content

feat(compute): update discovery doc and generate new services - #16483

Merged
colinmoy merged 4 commits into
googleapis:mainfrom
google-cloud-cpp-bot:automation/update-compute-discovery
Sep 28, 2026
Merged

colinmoy merged 4 commits into
googleapis:mainfrom
google-cloud-cpp-bot:automation/update-compute-discovery

Conversation

@google-cloud-cpp-bot

Copy link
Copy Markdown
Contributor

Automated update of Compute Engine Discovery Document and generated C++ client code.

Triggered automatically by the update-compute-discovery workflow.

@github-actions github-actions Bot added the api: compute Issues related to the Compute Engine API. label Sep 23, 2026
@google-cla

google-cla Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new generated services to the Google Cloud Compute C++ SDK, specifically global_frontend_settings, image_views, managed_rulesets, and project_views. This includes the generation of clients, connections, REST stubs, mocks, and samples for these services, alongside updates to environment variables and documentation. The review feedback highlights style guide violations in the generated code, specifically the use of default parameters within internal namespaces in GlobalFrontendSettingsRestMetadata and the use of auto type deduction obscuring a StatusOr return type in the client samples. These issues should be addressed by updating the code generator rather than modifying the generated files directly.

@colinmoy

Copy link
Copy Markdown
Collaborator

/gcbrun

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.33%. Comparing base (1223af0) to head (aebdd44).

Files with missing lines Patch % Lines
docfx/doxygen2markdown.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16483      +/-   ##
==========================================
- Coverage   92.35%   92.33%   -0.03%     
==========================================
  Files        2258     2258              
  Lines      216448   216448              
==========================================
- Hits       199909   199848      -61     
- Misses      16539    16600      +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart

Copy link
Copy Markdown
Member

/gcbrun

@colinmoy
colinmoy merged commit 730bf6e into googleapis:main Sep 28, 2026
63 checks passed

This branch was successfully deployed

1 active deployment
false — aebdd44a Deployed Sep 28, 2026 by google-cloud-cpp-bot via Save PR ref #12101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants