chore: add sharding to docs test - #18506
Open
daniel-sanche wants to merge 4 commits into
Open
daniel-sanche wants to merge 4 commits into
daniel-sanche wants to merge 4 commits into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
daniel-sanche
added
the
unit_test:all_packages
daniel-sanche
changed the title
daniel-sanche
marked this pull request as ready for review
September 30, 2026 21:46
ohmayr
reviewed
Sep 30, 2026
|
|
||
| jobs: | ||
| docs: | ||
| initialize: |
Contributor
There was a problem hiding this comment.
Do we need PACKAGE_WEIGHTS similar to other jobs?
Contributor
Author
There was a problem hiding this comment.
We don't need to add weights, that's just to help the system find a more equal distribution of packages.
But good suggestion, I'll add that here too. I think that can let us cut down on the number of shards, and still stay ~10 mins
ohmayr
approved these changes
Sep 30, 2026
daniel-sanche
added
the
do not merge
Contributor
Author
|
Adding do not merge until tomorrow's release goes out. I don't want to make CI changes that could cause issues |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs test took > 2 hours on a previous run today. This PR adds the sharding system to docs, to bring the test time down